Skip to content

Unbreak ISPRS Potsdam example #2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

Unbreak ISPRS Potsdam example #2319

merged 2 commits into from
Apr 4, 2025

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Mar 26, 2025

Overview

The label files in the Potsdam dataset are not georeferenced. Historically, RV had allowed SS label files to be non-georeferenced, but at some point not too long ago, this changed. This broke the ISPRS Potsdam example. This was not caught earlier because the files used during the pre-release testing had been modified to be georeferenced.

This PR makes it so that if the label source is not georeferenced but is the same size as the raster source, RV assumes they are fully aligned. This unbreaks the ISPRS Potsdam example.

Checklist

  • Added unit tests, if applicable
  • Updated documentation, if applicable
  • Added needs-backport label if the change should be back-ported to the previous release
  • PR has a name that won't get you publicly shamed for vagueness

Notes

N/A

Testing Instructions

This was tested to work on a fresh download of the ISPRS Potsdam dataset.

@AdeelH AdeelH force-pushed the potsdam-fix branch 2 times, most recently from 79ce415 to 64135bc Compare March 31, 2025 19:18
@AdeelH AdeelH marked this pull request as ready for review April 4, 2025 16:55
@AdeelH AdeelH merged commit 558221c into azavea:master Apr 4, 2025
1 check passed
@AdeelH AdeelH deleted the potsdam-fix branch April 4, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant