Log errors by default #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vadorovsky looks like eff4440 accidentally lost logging if an explicit level was not passed to the CLI. |
Merged
vadorovsky
reviewed
Apr 19, 2024
|
Go ahead and merge when you're satisfied. |
alessandrod
reviewed
Apr 20, 2024
There was a problem hiding this comment.
lgtm but let's let @vadorovsky try what he wants to try.
As per comment I wouldn't add a new dep tho.
src/bin/bpf-linker.rs
Outdated
| error(&e.to_string(), clap::error::ErrorKind::Format); | ||
| } | ||
| } | ||
| either::for_both!(subscriber, s => tracing::subscriber::set_global_default(s))?; |
There was a problem hiding this comment.
unless it's already in the dep tree, it doesn't seem worth adding a new dep just for this?
There was a problem hiding this comment.
Take a look at Cargo.lock; it's already in there.
There was a problem hiding this comment.
It's a dev dependency right?
Remove imperative `clap::Error::exit`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove imperative
clap::Error::exit.