Appease nightly clippy #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
approved these changes
Apr 18, 2024
|
This failure seems legit though, it seems like linking with C module (providing an anon struct) regressed: I can try to fix it later today if you need. |
|
Yeah it seems the regression is somewhere in rust-lang/rust@1cec373...becebb3. I don't have a Linux machine on hand so I'd appreciate your help. I'm trying to get better output in CI. |
tamird
force-pushed
the
clippy
branch
3 times, most recently
from
e421050 to
d6ac724
Compare
|
Well I got more output, but it's not super helpful: |
tamird
force-pushed
the
clippy
branch
4 times, most recently
from
b73904f to
dd58a02
Compare
warning: field `0` is never read
--> src/llvm/types/ir.rs:115:11
|
115 | Other(LLVMValueRef),
| ----- ^^^^^^^^^^^^
| |
| field in this variant
|
= note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
115 | Other(()),
| ~~
error: usage of a legacy numeric constant
--> src/linker.rs:525:55
|
525 | format!("--unroll-max-upperbound={}", std::u32::MAX).into(),
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
note: the lint level is defined here
--> src/lib.rs:1:9
|
1 | #![deny(clippy::all)]
| ^^^^^^^^^^^
= note: `#[deny(clippy::legacy_numeric_constants)]` implied by `#[deny(clippy::all)]`
help: use the associated constant instead
|
525 | format!("--unroll-max-upperbound={}", u32::MAX).into(),
| ~~~~~~~~
error: usage of a legacy numeric constant
--> src/linker.rs:526:50
|
526 | format!("--unroll-threshold={}", std::u32::MAX).into(),
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
526 | format!("--unroll-threshold={}", u32::MAX).into(),
| ~~~~~~~~
|
@vadorovsky I've pinned nightly to 2024-04-16 to unblock this. I extracted the logging changes to #197 which I'll rebase after this merges. |
|
Awesome! Sorry that I didn't help yesterday. Hopefully I will find some time to bisect today. |
|
@vadorovsky been a few months and we're still pinned. Would be really good to figure this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.