Remove hard failure for not getting global STS endpoint #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayanthvn
reviewed
Sep 12, 2024
jayanthvn
approved these changes
Sep 12, 2024
This needs to be tested for other regions. I think, we rely on global endpoint if the regional endpoint is not available. But post merge is fine. |
yash97
pushed a commit
to yash97/amazon-vpc-resource-controller-k8s
that referenced
this pull request
Oct 9, 2024
yash97
pushed a commit
to yash97/amazon-vpc-resource-controller-k8s
that referenced
this pull request
Oct 10, 2024
yash97
added a commit
that referenced
this pull request
Oct 22, 2024
* add finalizer handler in v1.4 * fix an err variable * adding logs for mismatched CNINode * add metrics for mismatches * update EC2 instance types * Update aws-sdk-go and change way to get regional sts endpoint (#466) * Missing dependency update * Remove hard failure for not getting global STS endpoint (#467) * updating k8s manifest * chaning go to major.minor format (#477) * updating go version and controller-gen version (#464) * Add new target for building docker images with no tests (#415) * updating rbac * Add Windows secondary IP mode configurable options for managing IP address allocation (#443) * Add Windows secondary IP mode configurable options (#443) #443 * Various code fixes for PR feedback #443 * adding ctx in test * updating ec2 supported instance types (#475) --------- Co-authored-by: Hao Zhou <[email protected]> Co-authored-by: Jay Deokar <[email protected]> Co-authored-by: Jay Deokar <[email protected]> Co-authored-by: Tatenda Zifudzi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
We don't use global STS endpoint so in case global endpoint is not found, ignore and move ahead with regional STS provider
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.