Skip to content

updating go version and controller-gen version #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

yash97
Copy link
Contributor

@yash97 yash97 commented Sep 6, 2024

Issue #, if available:

Description of changes:
updating controller-gen: Ref Issue kubernetes-sigs/controller-tools#888.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yash97 yash97 requested a review from a team as a code owner September 6, 2024 03:43
Copy link
Contributor

@sushrk sushrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@haouc haouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yash97 yash97 merged commit 712887d into aws:master Sep 10, 2024
4 checks passed
yash97 added a commit to yash97/amazon-vpc-resource-controller-k8s that referenced this pull request Sep 10, 2024
yash97 added a commit to yash97/amazon-vpc-resource-controller-k8s that referenced this pull request Oct 10, 2024
yash97 added a commit that referenced this pull request Oct 22, 2024
* add finalizer handler in v1.4

* fix an err variable

* adding logs for mismatched CNINode

* add metrics for mismatches

* update EC2 instance types

* Update aws-sdk-go and change way to get regional sts endpoint (#466)

* Missing dependency update

* Remove hard failure for not getting global STS endpoint (#467)

* updating k8s manifest

* chaning go to major.minor format (#477)

* updating go version and controller-gen version (#464)

* Add new target for building docker images with no tests (#415)

* updating rbac

* Add Windows secondary IP mode configurable options for managing IP address allocation (#443)

* Add Windows secondary IP mode configurable options (#443)

#443

* Various code fixes for PR feedback

#443

* adding ctx in test

* updating ec2 supported instance types (#475)

---------

Co-authored-by: Hao Zhou <[email protected]>
Co-authored-by: Jay Deokar <[email protected]>
Co-authored-by: Jay Deokar <[email protected]>
Co-authored-by: Tatenda Zifudzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants