Skip to content

Fix mypy and add snowflake sensor dag to master dag #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 3, 2023
Merged

Fix mypy and add snowflake sensor dag to master dag #907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c32bf21
Add snowflake sensor to run as part of master dag
rajaths010494 Mar 2, 2023
95b1363
Fix mypy
rajaths010494 Mar 3, 2023
06ae20e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 3, 2023
80de276
Fix mypy
rajaths010494 Mar 3, 2023
f3c281d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 3, 2023
e71cf77
fix mypy
rajaths010494 Mar 3, 2023
1ea9fc0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 3, 2023
fd65178
fix mypy
rajaths010494 Mar 3, 2023
b368d51
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 3, 2023
8c7db67
Update astronomer/providers/snowflake/hooks/snowflake.py
rajaths010494 Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/integration-tests/master_dag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ def prepare_dag_dependency(task_info, execution_time):
snowflake_task_info = [
{"snowflake_dag": "example_snowflake"},
{"snowflake_sql_api_dag": "example_snowflake_sql_api"},
{"example_snowflake_sensor": "example_snowflake_sensor"},
]
snowflake_trigger_tasks, ids = prepare_dag_dependency(snowflake_task_info, "{{ ds }}")
dag_run_ids.extend(ids)
Expand Down
5 changes: 3 additions & 2 deletions astronomer/providers/snowflake/hooks/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

def fetch_all_snowflake_handler(
cursor: SnowflakeCursor,
) -> list[tuple[Any, ...]] | list[dict[str, Any]] | None:
) -> list[dict[str, Any] | tuple[Any, ...] | None]:
"""Handler for SnowflakeCursor to return results"""
return cursor.fetchall()

Expand Down Expand Up @@ -88,7 +88,8 @@ def run( # type: ignore[override]
cur.execute_async(sql_statement)
query_id = cur.sfqid
self.log.info("Snowflake query id: %s", query_id)
self.query_ids.append(query_id)
if query_id:
self.query_ids.append(query_id)

# If autocommit was set to False for db that supports autocommit,
# or if db does not supports autocommit, we do a manual commit.
Expand Down