Skip to content

Fix mypy and add snowflake sensor dag to master dag #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 3, 2023

Conversation

rajaths010494
Copy link
Contributor

@rajaths010494 rajaths010494 commented Mar 2, 2023

Fix mypy issues on main and currently, the example_snowflake_sensor dag was not included as part of the master dag and this dag was not running on astro cloud.
This PR adds the example_snowflake_sensor into master_dag.

@rajaths010494 rajaths010494 changed the title Add snowflake sensor example dag to run as part of master dag Fix mypy and add snowflake sensor dag to master dag Mar 3, 2023
@rajaths010494 rajaths010494 force-pushed the add_snowflake_sensor branch from 922dd6f to b368d51 Compare March 3, 2023 07:06
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (ce01ee7) 98.61% compared to head (8c7db67) 98.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #907   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          89       89           
  Lines        4987     4988    +1     
=======================================
+ Hits         4918     4919    +1     
  Misses         69       69           
Impacted Files Coverage Δ
astronomer/providers/snowflake/hooks/snowflake.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rajaths010494 rajaths010494 requested a review from pankajkoti March 3, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants