Skip to content

Introducing Window Query + DataFrame API #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2018
Merged

Conversation

JulienPeloton
Copy link
Member

This PR re-introduces the Window query method, but with the DataFrame API.

The core of the routine remains untouched (using RDD), but the I/O are different. It takes a DataFrame as input, and return a DataFrame containing the coordinates of the objects found in the window.

@codecov-io
Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #112 into master will increase coverage by 1.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #112      +/-   ##
=========================================
+ Coverage   89.72%   90.8%   +1.07%     
=========================================
  Files          32      33       +1     
  Lines        1178    1229      +51     
  Branches      194     202       +8     
=========================================
+ Hits         1057    1116      +59     
+ Misses        121     113       -8
Flag Coverage Δ
#python 93.65% <ø> (+2.4%) ⬆️
#scala 89.54% <100%> (+0.46%) ⬆️
Impacted Files Coverage Δ
src/main/scala/com/spark3d/Queries.scala 100% <100%> (ø) ⬆️
...cala/com/spark3d/spatialOperator/WindowQuery.scala 100% <100%> (ø)
src/main/scala/com/spark3d/utils/Utils.scala 97.05% <0%> (+2.94%) ⬆️
queries.py 100% <0%> (+58.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5546f2...b4b29b0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants