Skip to content

Disable cargo xwin clippy in trampoline job #8182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Disable cargo xwin clippy in trampoline job #8182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,16 +353,17 @@ jobs:
with:
tool: cargo-xwin,cargo-bloat

- name: "Install xwin dependencies"
run: sudo apt-get install --no-install-recommends -y lld llvm clang cmake ninja-build

- name: "Clippy"
working-directory: ${{ github.workspace }}/crates/uv-trampoline
if: matrix.target-arch == 'x86_64'
run: cargo xwin clippy --all-features --locked --target x86_64-pc-windows-msvc --tests -- -D warnings
env:
XWIN_ARCH: "x86_64"
XWIN_CACHE_DIR: "${{ github.workspace }}/.xwin"
# xwin is currently broken. See https://github.com/rust-cross/cargo-xwin/issues/127
# - name: "Install xwin dependencies"
# run: sudo apt-get install --no-install-recommends -y lld llvm clang cmake ninja-build
#
# - name: "Clippy"
# working-directory: ${{ github.workspace }}/crates/uv-trampoline
# if: matrix.target-arch == 'x86_64'
# run: cargo xwin clippy --all-features --locked --target x86_64-pc-windows-msvc --tests -- -D warnings
# env:
# XWIN_ARCH: "x86_64"
# XWIN_CACHE_DIR: "${{ github.workspace }}/.xwin"

- name: "Bloat Check"
working-directory: ${{ github.workspace }}/crates/uv-trampoline
Expand Down
Loading