Skip to content

Disable cargo xwin clippy in trampoline job #8182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Oct 14, 2024

@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Oct 14, 2024
@zanieb zanieb enabled auto-merge (squash) October 14, 2024 18:29
@zanieb zanieb merged commit cc9767c into main Oct 14, 2024
61 checks passed
@zanieb zanieb deleted the zb/disable-xin-trampoline branch October 14, 2024 18:29
@samypr100
Copy link
Collaborator

@zanieb Could it be this rust-cross/cargo-xwin#127 (comment)

I think we should bump the timeout first to let it refresh the Windows SDK download (which can take 10+ minutes uncached)

samypr100 added a commit to samypr100/uv that referenced this pull request Oct 14, 2024
zanieb pushed a commit that referenced this pull request Oct 14, 2024
## Summary

Reverts #8181 and #8182.

The fix is in b849f0f, which extends the run timeout to allow xwin to
download the Windows SDK files, which can take 10+ minutes.

Closes rust-cross/cargo-xwin#127

## Test Plan

Existing CI should pass.

## Notes

xwin jobs will take a long time the first time due to cache re-warming.
zanieb added a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants