fix(controller): allow exit handler variables in resource template manifests. Fixes #14368 #14465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkschneider
force-pushed
the
fix-wf-of-wf-exit-handler
branch
from
caa1a4e to
cccc42a
Compare
Signed-off-by: Markus Schneider <[email protected]>
mrkschneider
force-pushed
the
fix-wf-of-wf-exit-handler
branch
from
cccc42a to
242a472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14368
Motivation
Using
{{workflow.failures}}within an exit handler in a resource template (workflow of workflows) caused a validation error. The changes allow to use{{workflow.failures}}in this context.Modifications
For template validation, if the template contains a resource manifest,
{{workflow.failures}}is replaced by a temporary placeholder to allow validation to pass. The strategy mirrors what already happens, e.g., when a exit hook is detected in the template.Verification
Unit test was added. Test workflow from #14368 can now run without problems.
Documentation
Bugfix. Existing documentation suggests that
{{workflow.failures}}should work in all contexts where exit handlers are used, including from within a workflow of workflows