fix: allow exit handler variables in resource template manifests

Signed-off-by: Markus Schneider <[email protected]>

Author: mrkschneider

workflow/validate/validate.go

@@ -244,6 +244,14 @@ func ValidateWorkflow(wftmplGetter templateresolution.WorkflowTemplateNamespaced
 		return errors.New(errors.CodeBadRequest, "spec.entrypoint is required")
 	}
 
+	// if resource templates are present, workflow failure variables may appear in the manifest
+	for _, tmpl := range wf.Spec.Templates {
+		if tmpl.Resource != nil && tmpl.Resource.Manifest != "" {
+			ctx.globalParams[common.GlobalVarWorkflowFailures] = placeholderGenerator.NextPlaceholder()
+			break
+		}
+	}
+
 	if !opts.IgnoreEntrypoint {
 		var args wfv1.ArgumentsProvider
 		args = &wfArgs

workflow/validate/validate_test.go

@@ -1041,6 +1041,47 @@ spec:
       args: ["echo {{workflow.failures}}"]
 `
 
+var workflowStatusInResourceTemplateManifest = `
+apiVersion: argoproj.io/v1alpha1
+kind: Workflow
+metadata:
+  generateName: exit-handlers-parent-workflow-
+spec:
+  entrypoint: trigger-child-workflow
+  serviceAccountName: argo
+  templates:
+    - name: trigger-child-workflow
+      resource:
+        action: create
+        manifest: |
+          apiVersion: argoproj.io/v1alpha1
+          kind: Workflow
+          metadata:
+            generateName: {{workflow.name}}-child-workflow-
+          spec:
+            entrypoint: main
+            onExit: exit-handler
+            templates:
+              - name: main
+                dag:
+                  tasks:
+                    - name: say-hello-task
+                      template: say-hello
+              - name: say-hello
+                script:
+                  image: alpine:latest
+                  command: [sh]
+                  source: |
+                    echo "hello from child workflow"
+              - name: exit-handler
+                script:
+                  image: alpine:latest
+                  command: [sh]
+                  source: |
+                    echo "hello from exit handler"
+                    echo '{{workflow.failures}}'
+`
+
 func TestExitHandler(t *testing.T) {
 	// ensure {{workflow.status}} is not available when not in exit handler
 	err := validate(workflowStatusNotOnExit)
@@ -1049,6 +1090,10 @@ func TestExitHandler(t *testing.T) {
 	// ensure {{workflow.status}} is available in exit handler
 	err = validate(exitHandlerWorkflowStatusOnExit)
 	require.NoError(t, err)
+
+	// ensure {{workflow.status}} is available when in resource template manifest
+	err = validate(workflowStatusInResourceTemplateManifest)
+	require.NoError(t, err)
 }
 
 var workflowWithPriority = `