fix: gracefully handle invalid CronWorkflows and simplify logic. (cherry-pick #14197) #14419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rry-pick argoproj#14197) This cherry-picks argoproj#14197 onto `release-3.6`. I had to resolve a conflict in `ui/src/cron-workflows/cron-workflow-row.tsx` because that file doesn't exist in the release branch, since it was added in db6206a by extracting code from `ui/src/cron-workflows/cron-workflow-list.tsx`. Signed-off-by: Mason Malone <[email protected]>
kim-codefresh
added a commit
to codefresh-io/argo-workflows
that referenced
this pull request
May 20, 2025
…abilities fixes (Cr 28355) (#358) * fix: bump deps for k8schain to fix ecr-login (argoproj#14008) (release-3.6 cherry-pick) (argoproj#14174) * fix(ci): python sdk release process (release-3.6) (argoproj#14183) Signed-off-by: Alan Clucas <[email protected]> * docs: clarify qps/burst on controller (cherry-pick argoproj#14190) (argoproj#14192) Signed-off-by: Tim Collins <[email protected]> Co-authored-by: Tim Collins <[email protected]> * fix(api/jsonschema): use unchanging JSON Schema version (cherry-pick argoproj#14092) (argoproj#14256) Signed-off-by: Roger Peppe <[email protected]> Co-authored-by: Roger Peppe <[email protected]> * fix(api/jsonschema): use working `$id` (cherry-pick argoproj#14257) (argoproj#14258) Signed-off-by: Roger Peppe <[email protected]> Co-authored-by: Roger Peppe <[email protected]> * docs: autogenerate tested k8s versions and centralize config (argoproj#14176) (release-3.6) (argoproj#14262) Signed-off-by: Mason Malone <[email protected]> Signed-off-by: Alan Clucas <[email protected]> Co-authored-by: Mason Malone <[email protected]> * chore(deps): bump minio-go to newer version (argoproj#14185) (release-3.6) (argoproj#14261) Co-authored-by: Vaibhav Kaushik <[email protected]> * fix: split pod controller from workflow controller (argoproj#14129) (release-3.6) (argoproj#14263) * chore(deps): fix snyk (argoproj#14264) (release-3.6) (argoproj#14268) * chore: revert to correct k8s versions Accidental bump from argoproj#14176 cherry-pick Signed-off-by: Alan Clucas <[email protected]> * chore(deps): bump github.com/go-jose/go-jose/v3 from 3.0.3 to 3.0.4 in the go_modules group (cherry-pick argoproj#14231) (argoproj#14269) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: wait for workflow informer to sync before pod informer (cherry-pick argoproj#14248) (argoproj#14266) Signed-off-by: Rohan K <[email protected]> Co-authored-by: Rohan K <[email protected]> * fix(cli): remove red from log colour selection. Fixes argoproj#6740 (cherry-pick argoproj#14215) (argoproj#14278) Signed-off-by: Prabakaran Kumaresshan <[email protected]> Co-authored-by: Prabakaran Kumaresshan <[email protected]> * fix: correct semaphore configmap keys for multiple semaphores (argoproj#14184) (release-3.6) (argoproj#14281) * fix: don't print help for non-validation errors. Fixes argoproj#14234 (cherry-pick argoproj#14249) (argoproj#14283) Signed-off-by: Koichi Shimada <[email protected]> Signed-off-by: Mason Malone <[email protected]> Co-authored-by: koichi <[email protected]> Co-authored-by: Mason Malone <[email protected]> * docs: fix kubernetes versions (release-3.6) (argoproj#14273) Signed-off-by: Alan Clucas <[email protected]> * fix(workflow/sync): use RWMutex to prevent concurrent map access (cherry-pick argoproj#14321) (argoproj#14322) Signed-off-by: Ryan Currah <[email protected]> Co-authored-by: Ryan Currah <[email protected]> * chore(lint): update golangci-lint to 2.1.1 (argoproj#14390) (cherry-pick release-3.6) (argoproj#14417) * chore: bump golang 1.23->1.24 (argoproj#14385) (cherry-pick release-3.6) (argoproj#14418) * fix: gracefully handle invalid CronWorkflows and simplify logic. (cherry-pick argoproj#14197) (argoproj#14419) Signed-off-by: Mason Malone <[email protected]> * fix: prevent dfs sorter infinite recursion on cycle. Fixes argoproj#13395 (cherry-pick argoproj#14391) (argoproj#14420) Signed-off-by: Adrien Delannoy <[email protected]> Co-authored-by: Adrien Delannoy <[email protected]> * chore(deps): bump github.com/expr-lang/expr from 1.16.9 to 1.17.0 (argoproj#14307) (release-3.6) (argoproj#14421) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps)!: update k8s and argo-events (release-3.6) (argoproj#14424) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: william.vanhevelingen <[email protected]> Signed-off-by: Mason Malone <[email protected]> Signed-off-by: William Van Hevelingen <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: William Van Hevelingen <[email protected]> Co-authored-by: Mason Malone <[email protected]> * fix: correct retry logic (argoproj#13734) (release-3.6) (argoproj#14428) Signed-off-by: isubasinghe <[email protected]> Signed-off-by: Alan Clucas <[email protected]> Co-authored-by: Isitha Subasinghe <[email protected]> * fix: manual retries exit handler cleanup. Fixes argoproj#14180 (argoproj#14181) (release-3.6) (argoproj#14429) Signed-off-by: isubasinghe <[email protected]> Signed-off-by: Alan Clucas <[email protected]> Co-authored-by: Isitha Subasinghe <[email protected]> * fix: correct manual retry logic. Fixes argoproj#14124 (argoproj#14328) (release-3.6) (argoproj#14430) Signed-off-by: oninowang <[email protected]> Signed-off-by: Alan Clucas <[email protected]> Co-authored-by: jswxstw <[email protected]> * fix: disable ALPN in argo-server as a workaround (argoproj#14433) Signed-off-by: Alan Clucas <[email protected]> * result of codegen Signed-off-by: Kim <[email protected]> * fix:lint Signed-off-by: Kim <[email protected]> --------- Signed-off-by: Alan Clucas <[email protected]> Signed-off-by: Tim Collins <[email protected]> Signed-off-by: Roger Peppe <[email protected]> Signed-off-by: Mason Malone <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Rohan K <[email protected]> Signed-off-by: Prabakaran Kumaresshan <[email protected]> Signed-off-by: Koichi Shimada <[email protected]> Signed-off-by: Ryan Currah <[email protected]> Signed-off-by: Adrien Delannoy <[email protected]> Signed-off-by: william.vanhevelingen <[email protected]> Signed-off-by: William Van Hevelingen <[email protected]> Signed-off-by: isubasinghe <[email protected]> Signed-off-by: oninowang <[email protected]> Signed-off-by: Kim <[email protected]> Co-authored-by: Alan Clucas <[email protected]> Co-authored-by: gcp-cherry-pick-bot[bot] <98988430+gcp-cherry-pick-bot[bot]@users.noreply.github.com> Co-authored-by: Tim Collins <[email protected]> Co-authored-by: Roger Peppe <[email protected]> Co-authored-by: Mason Malone <[email protected]> Co-authored-by: Vaibhav Kaushik <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rohan K <[email protected]> Co-authored-by: Prabakaran Kumaresshan <[email protected]> Co-authored-by: koichi <[email protected]> Co-authored-by: Ryan Currah <[email protected]> Co-authored-by: Adrien Delannoy <[email protected]> Co-authored-by: William Van Hevelingen <[email protected]> Co-authored-by: Isitha Subasinghe <[email protected]> Co-authored-by: jswxstw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This manually cherry-picks #14197 onto
release-3.6, as requested in #14197 (comment).Modifications
Ran
git cherry-pick -s e9e7c4398c00621f697acf0002b7992028958daa. I had to resolve a conflict inui/src/cron-workflows/cron-workflow-row.tsxbecause that file doesn't exist in the release branch, since it was added in db6206a by extracting code fromui/src/cron-workflows/cron-workflow-list.tsx.Verification
Same testing procedure as #14197:
Documentation
N/A