Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document server side pagination proposal #17222

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Feb 15, 2024

PR contains a proposal for a server-side pagination feature. #14947

Signed-off-by: Alexander Matyushentsev <[email protected]>
@prashant-shahi
Copy link
Contributor

Looking forward for this 🚀

Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a great feature and a no-brainer. Do you need additional reviewers/approvers? I'd be happy to volunteer if needed.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for putting this together!

I do think that it's the right thing to move things like filtering from the client side to the server side.

**Pagination Cursor**

It is proposed to add `offset` and `limit` fields for pagination support in Application List API.
The The Watch API is a bit more complex. Both Argo CD user interface and CLI are relying on the Watch API to display real time updates of Argo CD applications.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The The Watch API is a bit more complex. Both Argo CD user interface and CLI are relying on the Watch API to display real time updates of Argo CD applications.
The Watch API is a bit more complex. Both Argo CD user interface and CLI are relying on the Watch API to display real time updates of Argo CD applications.

@i551110
Copy link

i551110 commented Apr 15, 2024

I am not sure if I am missing something, but can we merge this?

@kencochrane
Copy link

This looks great; thanks for writing this up.

@christianh814
Copy link
Member

@crenshaw-dev So Alex has been out sick the past few days. Sorry for the delay but I'll have him follow as soon as he's back

@naturboy
Copy link

@christianh814 It's been a while since your last comment. I hope @alexmt has recovered. Maybe one of you two can answer the following questions:

  1. What's the status on this proposal? It would be nice if we can get the questions by the reviewers above answered to continue to improve the ArgoCD ui.
  2. Has @akuityio an implementation for this already, or does someone still need to implement this feature after this proposal goes through? I am interested in bringing this feature to ArgoCD.

@christianh814
Copy link
Member

@christianh814 It's been a while since your last comment. I hope @alexmt has recovered. Maybe one of you two can answer the following questions:

1. What's the status on this proposal? It would be nice if we can get the questions by the reviewers above answered to continue to improve the ArgoCD ui.

I will let @alexmt update on this.

2. Has @akuityio an implementation for this already, or does someone still need to implement this feature after this proposal goes through? I am interested in bringing this feature to ArgoCD.

Yes we have an implementation on this already. Alex has needs to make some changes to generalize it. He posted about it HERE

@aliazlan-t
Copy link

so are we ready to ship it? 🎆

Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Enough information in this proposal to start the implementation. Some improvements could be

  • Extract the fields for query filtering in their own objects such as ApplicationQueryFilter
  • Research the pagination best practice and evaluate if offset/limit is the best strategy
  • Describe the metadata that will be returned to the UI (such as total items, etc.)

@agaudreault agaudreault merged commit 6b5cdc7 into argoproj:master Oct 10, 2024
10 of 15 checks passed
ali-hamza-noor pushed a commit to ali-hamza-noor/argo-cd that referenced this pull request Oct 10, 2024
Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: alnoor <[email protected]>
austin5219 pushed a commit to austin5219/argo-cd that referenced this pull request Oct 16, 2024
Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: austin5219 <[email protected]>
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: Adrian Aneci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.