Add configuration reader script #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivdb
reviewed
Oct 13, 2020
scripts/configReader.js
Outdated
| } else { | ||
| const fileName = env ? `${network}.${env}.json` : `${network}.json`; | ||
| const filePath = path.join(__dirname, "./config", fileName); | ||
| configLoader = new ConfiguratorLoader.Local(filePath); |
There was a problem hiding this comment.
Is this really useful? If there is a local json config file, we could just open this file directly without requiring a script, no?
|
Instead of having to read it via a script, could we not simply have an unauthenticated GET request that returns the file from S3? @gergold |
juniset
approved these changes
Oct 16, 2020
|
@olivdb The config file contains some information about our AWS configuration which we might not want to expose publicly. |
olivdb
reviewed
Oct 16, 2020
scripts/configReader.js
Outdated
| const configurator = new Configurator(configLoader); | ||
| await configurator.load(); | ||
| const configuration = configurator.copyConfig(); | ||
| console.log(configuration); |
There was a problem hiding this comment.
Could we JSON.stringify the configuration so that all subfields display properly?
elenadimitrova
force-pushed
the
maintenance/configuration-reader
branch
2 times, most recently
from
01e0244 to
9cd03e7
Compare
olivdb
approved these changes
Oct 19, 2020
elenadimitrova
force-pushed
the
maintenance/configuration-reader
branch
from
ce6ba34 to
694124d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to read configuration files easily. Note that config is read without verification to allow us to read potentially invalid config. The script does the validation at the end and logs any schema validation errors. I added this logic after noticing the current staging configuration is invalid due to the missing
ArgentWalletDetectorschema property.