Cleaning the scripts we use to manage the contracts owned by the multisig #161
Conversation
scripts/execute_script.sh
Outdated
| # rm -rf build | ||
| # npm run compile:lib | ||
| # npm run compile | ||
| # npm run compile:legacy |
There was a problem hiding this comment.
I'm for this change considering how long compilation takes currently however the obvious risk is that we execute scripts without compiling to latest version of the contracts. As a prevention, can we add some warning text in the comments header of scripts using execute_script to say COMPILE CONTRACTS BEFORE RUNNING or something similar?
There was a problem hiding this comment.
Agreed. Actually I've added a --no-compile flag in #156 (https://github.com/argentlabs/argent-contracts/pull/156/files#diff-0aa9ab67bc9291891ca0b035f24dce95R12) to address that. We can either wait for #156 to be merged or I can include that change in this PR.
There was a problem hiding this comment.
I don't mind either way.
scripts/update_compound_registry.js
Outdated
| // ./execute_script.sh update_compound_registry.js <network> --remove --token <token address> | ||
| // | ||
| // where: | ||
| // - network = [test, staging, prod] |
There was a problem hiding this comment.
Can the network not be ganache as well for local testing?
scripts/update_wallet_in_factory.js
Outdated
| // ./execute_script.sh update_wallet_in_factory.js <network> | ||
| // | ||
| // where: | ||
| // - network = [test, staging, prod] |
There was a problem hiding this comment.
Can we remove defaultNetwork = "test" in this script to mandate passing the network property
juniset
force-pushed
the
maintenance/clean_scripts
branch
from
6efde03 to
ab61485
Compare
juniset
force-pushed
the
maintenance/clean_scripts
branch
from
230878d to
a86bd3d
Compare
No description provided.