Introduce Sharedflow awareness to EP002 and PD005 #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- To consider Condition placements, and to report line numbers on the endpoint
file, checks must be on Step, not Policy. Therefore move PO00{1,2,3,4,5}
to ST00{3,4,5,6,7}, and re-design those plugins so they report on the Endpoint.
- Also introduce new tests for these cases, for Sharedflows.
- And modify Endpoint so that it correctly reports errors in Sharedflows.
(This never worked!) And introduce new tests to verify that this is
working correctly.
- also add EP002 test for sharedflows
- also add tests for specific formparams
these messages now include example conditions
migrate PO00{1,2,3,4,5} to ST00{3,4,5,6,7}
- also add EP002 test for sharedflows
|
Will close and replace with another. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to check for SharedFlows in these plugins.
This builds on top of #342