migrate PO00{1,2,3,4,5} to ST00{3,4,5,6,7}

[DinoChiesa]

This fixes issue #339

• To consider Condition placements, and to report line numbers on the endpoint file, these checks should be on the Step, not on the Policy, and should use onProxyEndpoint and onTargetEndpoint. Therefore move PO00{1,2,3,4,5} to ST00{3,4,5,6,7}, and re-factor those plugins so they report on the Endpoints.

• Also introduce new tests for these cases, for Sharedflows.

• And modify the Endpoint module so that it correctly reports errors in Sharedflows. (This never worked!) And introduce new tests to verify that this is working correctly. With this change, I see that EP002 and PD005 are incorrectly reporting errors on Step elements within SharedFlows. I will fix that in a subsequent PR.

[DinoChiesa]

Also see the PR #343

[ssvaidyanathan]

change to warning

[ssvaidyanathan]

change to warning

[kurtkanaskie]

Given a policy with:

<ExtractVariables continueOnError="false" enabled="true" name="Extract-Variables-FormParam">
  <DisplayName>Extract Variables-FormParam</DisplayName>
  <FormParam name="greeting">
    <Pattern>hello {user}</Pattern>
  </FormParam>
  <Variable name="name"/>
  <IgnoreUnresolvedVariables>true</IgnoreUnresolvedVariables>
</ExtractVariables>

I get 3 errors - ST005 - for the steps using Extract-Variables-FormParam policy.
I don't get those errors in the version 2.30.

  <PreFlow name="PreFlow">
    <Request>
      <Step>
        <Condition>(request.content != null)</Condition>
        <Name>Extract-Variables-1</Name>
      </Step>
      <Step>
        <Condition>(request.formparams.count != 0)</Condition>
        <Name>Extract-Variables-FormParam</Name>
      </Step>
      <Step>
        <Condition>(request.formparams.greeting)</Condition>
        <Name>Extract-Variables-FormParam</Name>
      </Step>
      <Step>
        <Condition>(request.content != null)</Condition>
        <Name>Extract-Variables-FormParam</Name>
      </Step>
      <Step>
        <Condition>(request.content != null)</Condition>
        <Name>Extract-Variables-1</Name>
      </Step>
    </Request>
    <Response/>
  </PreFlow>

[DinoChiesa]

I have modified ST005 , so that the condition must be one of these:

1. request.formstring != null
2. request.formparam.PARAMNAME != null, where PARAMNAME is the name cited in the policy in the FormParam element.

If there are multiple FormParam elements, then the plugin checks for a condition that checks at least one of them.

[DinoChiesa]

More changes coming. . . . .

[kurtkanaskie]

This took me awhile to find, given a policy without a Source element (optional - default uses message) or with a Source element that is anything but <Source>request</Source> I get insufficient Condition.

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<ExtractVariables continueOnError="false" enabled="true" name="Extract-Variables-FormParam">
  <DisplayName>Extract Variables-FormParam</DisplayName>
  <FormParam name="greeting">
    <Pattern>hello {user}</Pattern>
  </FormParam>
  <IgnoreUnresolvedVariables>true</IgnoreUnresolvedVariables>
</ExtractVariables>

These Conditions are insufficient without a Source element in the policy.

    <Request>
      <Step>
        <Condition>request.formstring != null</Condition>
        <Name>Extract-Variables-FormParam</Name>
      </Step>
      <Step>
        <Condition>request.formparam.greeting != null</Condition>
        <Name>Extract-Variables-FormParam</Name>
      </Step>

Easy to reproduce, just remove Source element from your test policy in EV-Formparam-1.xml

Also, I think we should add the test conditions to the warning message, it took me a while to figure out the right Condition.

Perhaps:
Use <Condition>request.formstring != null</Condition> or <Condition>request.formparam.PARAMNAME_FROM_POLICY != null</Condition>

[ssvaidyanathan]

@DinoChiesa - Should we add a note in the README about the plugin rule change from PO to ST?