Create and submit update transactions #69
Conversation
Siegrift
changed the title
| ); | ||
| }; | ||
|
|
||
| export const estimateMulticallGasLimit = async ( |
There was a problem hiding this comment.
Fully based on Airseeker v1 implementation. Later we might do #67 but that needs a discussion and agreement first.
There was a problem hiding this comment.
Hey, AFAIK in airseeker v1 a configured gas limit is used (gas for calls is not estimated).
Separately, manager-multisig often has to do multicalls and the gas is sometimes incorrectly estimated (often repeatedly for the same transaction). It's just something we should probably keep in mind; if we do estimates will we have a config parameter for adding headroom?
There was a problem hiding this comment.
Hey, AFAIK in airseeker v1 a configured gas limit is used (gas for calls is not estimated).
Mhh, are you sure? I based the implementation of the code in the main branch. I can see that we did the estimation here (for all beacons to be updated).
Separately, manager-multisig often has to do multicalls and the gas is sometimes incorrectly estimated (often repeatedly for the same transaction). It's just something we should probably keep in mind; if we do estimates will we have a config parameter for adding headroom?
Yeah, the estimating implementation seems a bit off, but I found the reasoning in:
- https://github.com/api3dao/airseeker/pull/481
- chore(deps): update non-major-dev-dependencies #447
- https://github.com/api3dao/manager-multisig/pull/214#issuecomment-1663995357
And the estimation function implemented here should have the same behaviour as the one in Airseeker (if not it's my mistake and should be fixed).
cc: @acenolaza since we talked about this a bit on Slack.
There was a problem hiding this comment.
if we do estimates will we have a config parameter for adding headroom?
There is 10% headroom added when we do estimate of the multicall, so I guess that covers the need for tryMulticall and also adds this headroom.
There was a problem hiding this comment.
It's possible I made a mistake, thanks for clarifying :)
The current Airseeker implementation works well, so it must be fine :)
| ); | ||
| }; | ||
|
|
||
| export const estimateMulticallGasLimit = async ( |
There was a problem hiding this comment.
Hey, AFAIK in airseeker v1 a configured gas limit is used (gas for calls is not estimated).
Separately, manager-multisig often has to do multicalls and the gas is sometimes incorrectly estimated (often repeatedly for the same transaction). It's just something we should probably keep in mind; if we do estimates will we have a config parameter for adding headroom?
Closes #36
Ideally merged after #65 so I can rebase and use the decoded
dataFeedvalue received from the contract.Rationalle
The logic is based of Airseeker v1. There could be some optimisations done, but I am not doing them just yet.
There are some subtle differences, most notably in the sponsor wallet derivation and the general architecture (how we process the dAPIs in batches).