Process on-chain-received DApi batches #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

aquarat merged 20 commits into main from 47-process-batches-two

Nov 7, 2023

Collaborator

aquarat commented Nov 2, 2023 •

edited

Loading

After a lot of rebasing, this PR:

Modifies recent work around the state to reflect the chain-agnostic nature of signed data
- and the fact that the contract can return multiple signed data URLs per single source data feed
Modifies the signed datastore to be datafeed ID indexed to better reflect how the data is used
Checks on-chain values against local values and produces a batch of update decisions

aquarat changed the title ~~WIP Preview PR~~ WIP Preview

aquarat added 2 commits

November 2, 2023 13:43


          Process dApis

37b916d


          Make nested lookup in gas-price.ts safer

01660e7

aquarat force-pushed the 47-process-batches-two branch from 5669cea to 01660e7 Compare

November 2, 2023 13:48

aquarat changed the title ~~WIP Preview~~ WIP

aquarat added 4 commits

November 2, 2023 15:46


          Modify state structure to reflect contract and fix tests

c857adb


          Polish

444d9f4


          Merge in main, resolve conflicts

f43e557


          Linting

1c58db2

aquarat changed the title ~~WIP~~ WIP Process on-chain-received DApi batches


          Fix e2e test

f0edd43

aquarat requested review from vponline and Siegrift

November 2, 2023 16:15

aquarat marked this pull request as ready for review

November 2, 2023 16:16

vponline reviewed

View reviewed changes

Contributor

vponline left a comment

This is looking great! Only some minor comments

src/state/state.ts Outdated Show resolved Hide resolved

src/update-feeds/update-feeds.ts Outdated Show resolved Hide resolved

test/fixtures/mock-config.ts Outdated Show resolved Hide resolved


          Add tests, PR comments, minor refactor

933da52

aquarat requested a review from vponline

November 3, 2023 12:08

aquarat changed the title ~~WIP Process on-chain-received DApi batches~~ Process on-chain-received DApi batches

Siegrift reviewed

View reviewed changes

src/types.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/utils.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/utils.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/utils.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/utils.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

test/e2e/update-feeds.feature.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/update-feeds/update-feeds.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/update-feeds/update-feeds.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/update-feeds/update-feeds.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/update-feeds/update-feeds.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/types.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/update-feeds/update-feeds.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/state/state.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/state/state.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/state/state.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/state/state.test.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/gas-price/gas-price.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

src/update-feeds/update-feeds.ts Outdated Show resolved Hide resolved


          Initial PR fixes

2f2d101

Siegrift mentioned this pull request

Create and submit update transactions #69

Merged

aquarat and others added 8 commits

November 6, 2023 11:07


          PR comments

ebff14e


          Replace received URLs instead of merge them

074a873


          Update src/types.ts

6ec5ed5

Co-authored-by: Emanuel Tesař <[email protected]>


          Remove dynamicState

e13f6cf


          Merge branch '47-process-batches-two' of github.com:api3dao/airseeker…

61dde03

…-v2 into 47-process-batches-two


          Fixes in response to PR suggestions

bfaadc7


          PR comments

10a4ab0


          Fix e2e tests

6dc143e

aquarat requested a review from Siegrift

November 6, 2023 12:25

Collaborator Author

aquarat commented Nov 6, 2023

Please check now @Siegrift

aquarat self-assigned this

Siegrift requested changes

View reviewed changes

src/signed-api-fetch/data-fetcher.ts Outdated Show resolved Hide resolved

src/state/state.ts Outdated Show resolved Hide resolved

src/update-feeds/update-feeds.test.ts Outdated Show resolved Hide resolved

src/update-feeds/update-feeds.ts Outdated Show resolved Hide resolved

src/update-feeds/update-feeds.ts Outdated Show resolved Hide resolved


          Index signed URLs by provider, revert some changes

3abe361

aquarat requested a review from Siegrift

November 7, 2023 09:14

Siegrift requested changes

View reviewed changes

Collaborator

Siegrift left a comment

Probably the last comment 🙏

src/update-feeds/update-feeds.ts Outdated Show resolved Hide resolved

aquarat added 2 commits

November 7, 2023 10:31


          Key signed api urls by chain id and provider name

7a2933e


          Simplify signed api url store set

06f680a

aquarat requested a review from Siegrift

November 7, 2023 10:54

Siegrift approved these changes

View reviewed changes

Collaborator

Siegrift left a comment

👍 LGTM

aquarat merged commit 6c697b6 into main

aquarat deleted the 47-process-batches-two branch

November 7, 2023 12:13

Siegrift mentioned this pull request

Signed API URLs need to be stored per Airnode #78

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet