Fix error handling and update transaction calldata #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
commented
Nov 28, 2023
| @@ -48,7 +48,6 @@ export const checkDeviationThresholdExceeded = ( | |||
| * | |||
| * Update transaction with stale data would revert on chain, draining the sponsor wallet. See: | |||
| * https://github.com/api3dao/airnode-protocol-v1/blob/dev/contracts/dapis/DataFeedServer.sol#L121 | |||
| * This can happen if the gateway or Airseeker is down and Airkeeper does the updates instead. | |||
There was a problem hiding this comment.
This part of the comment was outdated.
Siegrift
commented
Nov 28, 2023
| return true; | ||
| } | ||
| } else { | ||
| logger.info(`On-chain timestamp is older than the heartbeat interval.`); | ||
|
|
||
| logger.debug(`On-chain timestamp is older than the heartbeat interval.`); |
There was a problem hiding this comment.
The info level feels to high for this type of information.
Siegrift
commented
Nov 28, 2023
| value: decodeBeaconValue(signedData.encodedValue)!, | ||
| } | ||
| : undefined; | ||
| const isUpdatable = offChainValue?.timestamp.gt(onChainValue.timestamp); |
There was a problem hiding this comment.
We do not need to check offChainValue.timestamp.gt(Math.ceil(Date.now() / 1000 + 60 * 60)) because we already check that when we recieve the signed data.
Siegrift
commented
Nov 28, 2023
| logger.warn(`No active dAPIs found`); | ||
| return; | ||
| } | ||
| // NOTE: We need to explicitly handle the .catch here because it's possible that the promise settles before it's |
There was a problem hiding this comment.
This gave me a hard time to debug, but its actually correct. There is a sleep call below. If the promise resolves sooner it is unhandled (because we await it only a few lines below). To address this issue we need to catch the error ourselves.
aquarat
approved these changes
Nov 29, 2023
Siegrift
force-pushed
the
fix-error-handling
branch
from
ff8f1da to
6c12747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113
Rationale
I implemented the error handling as the issue says. As I was changing the
multicallBeaconValuesandgetUpdatableFeedsI decided to simplify it a bit by avoiding mutation in map/filter but I preserved the logic.I also noticed that we are incorrectly creating the beacon set update calldata. We need to update the beacon set with all beacons (not just the ones that are updatable). I've added a few tests to guard for this.