Skip to content

Fix incorrect beacon values multicall error handling #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Siegrift opened this issue Nov 23, 2023 · 0 comments · Fixed by #119
Closed

Fix incorrect beacon values multicall error handling #113

Siegrift opened this issue Nov 23, 2023 · 0 comments · Fixed by #119
Assignees

Comments

@Siegrift
Copy link
Collaborator

Here we re-throw an error that is not handled anywhere in the call chain. See image below:

image

Couple of things to change:

  • We should not re-throw the error
  • This check should be removed
  • Provider name here is unused and should be removed
  • I think we should handle the error here and return an empty array in case it happens.
  • Here I anticipated that processBatch function will not throw. I think this holds true (when we fix the issue), but we should have some last resort boundary (wrap in go and log unexpected error) in this function .
  • The message should have lowercase Updatable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant