Skip to content

[fix] chore: remove unused preciseTopicPublishRateLimiterEnable #24249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

dlg99
Copy link
Contributor

@dlg99 dlg99 commented May 5, 2025

Motivation

#21681 removed actual uses of preciseTopicPublishRateLimiterEnable config but left some plumbing (setting/reading config) in the code.

Modifications

Removing unused code

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: dlg99#23

@dlg99 dlg99 requested a review from lhotari May 5, 2025 18:49
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 5, 2025
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dlg99, LGTM

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.21%. Comparing base (bbc6224) to head (3b7f4ed).
Report is 1068 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24249      +/-   ##
============================================
+ Coverage     73.57%   74.21%   +0.63%     
+ Complexity    32624    32201     -423     
============================================
  Files          1877     1866      -11     
  Lines        139502   144972    +5470     
  Branches      15299    16561    +1262     
============================================
+ Hits         102638   107590    +4952     
+ Misses        28908    28869      -39     
- Partials       7956     8513     +557     
Flag Coverage Δ
inttests 26.72% <ø> (+2.13%) ⬆️
systests 23.31% <ø> (-1.02%) ⬇️
unittests 73.69% <ø> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...org/apache/pulsar/broker/ServiceConfiguration.java 98.16% <ø> (-1.23%) ⬇️
...rg/apache/pulsar/broker/service/AbstractTopic.java 87.98% <ø> (-0.01%) ⬇️
...rg/apache/pulsar/broker/service/BrokerService.java 83.48% <ø> (+2.70%) ⬆️

... and 1079 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dlg99 dlg99 merged commit 0cfed94 into apache:master May 5, 2025
54 of 55 checks passed
@lhotari lhotari added this to the 4.1.0 milestone May 6, 2025
lhotari pushed a commit that referenced this pull request May 9, 2025
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants