[fix] chore: remove unused preciseTopicPublishRateLimiterEnable (apache#24249)

(cherry picked from commit 0cfed94)

Author: dlg99

conf/broker.conf

@@ -389,9 +389,6 @@ unblockStuckSubscriptionEnabled=false
 # it uses more CPU to perform frequent check. (Disable publish throttling with value 0)
 topicPublisherThrottlingTickTimeMillis=10
 
-# Enable precise rate limit for topic publish
-preciseTopicPublishRateLimiterEnable=false
-
 # Tick time to schedule task that checks broker publish rate limiting across all topics
 # Reducing to lower value can give more accuracy while throttling publish but
 # it uses more CPU to perform frequent check. (Disable publish throttling with value 0)

conf/standalone.conf

@@ -260,9 +260,6 @@ keySharedLookAheadMsgInReplayThresholdPerSubscription=20000
 # it uses more CPU to perform frequent check. (Disable publish throttling with value 0)
 topicPublisherThrottlingTickTimeMillis=2
 
-# Enable precise rate limit for topic publish
-preciseTopicPublishRateLimiterEnable=false
-
 # Tick time to schedule task that checks broker publish rate limiting across all topics
 # Reducing to lower value can give more accuracy while throttling publish but
 # it uses more CPU to perform frequent check. (Disable publish throttling with value 0)

pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java

@@ -1041,11 +1041,6 @@ The max allowed delay for delayed delivery (in milliseconds). If the broker rece
                     + "it uses more CPU to perform frequent check. (Disable publish throttling with value 0)"
         )
     private int topicPublisherThrottlingTickTimeMillis = 10;
-    @FieldContext(
-            category = CATEGORY_SERVER,
-            doc = "Enable precise rate limit for topic publish"
-    )
-    private boolean preciseTopicPublishRateLimiterEnable = false;
 
     @FieldContext(
         category = CATEGORY_SERVER,

pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java

@@ -135,8 +135,6 @@ public abstract class AbstractTopic implements Topic, TopicPolicyListener {
     protected volatile PublishRateLimiter topicPublishRateLimiter;
     protected volatile ResourceGroupPublishLimiter resourceGroupPublishLimiter;
 
-    protected boolean preciseTopicPublishRateLimitingEnable;
-
     @Getter
     protected boolean resourceGroupRateLimitingEnabled;
 
@@ -193,7 +191,6 @@ public AbstractTopic(String topic, BrokerService brokerService) {
         updateTopicPolicyByBrokerConfig();
 
         this.lastActive = System.nanoTime();
-        this.preciseTopicPublishRateLimitingEnable = config.isPreciseTopicPublishRateLimiterEnable();
         topicPublishRateLimiter = new PublishRateLimiterImpl(brokerService.getPulsar().getMonotonicClock());
         updateActiveRateLimiters();
 

pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java

@@ -323,7 +323,6 @@ public class BrokerService implements Closeable {
     private Channel listenChannel;
     private Channel listenChannelTls;
 
-    private boolean preciseTopicPublishRateLimitingEnable;
     private BrokerInterceptor interceptor;
     private final EntryFilterProvider entryFilterProvider;
     private TopicFactory topicFactory;
@@ -339,8 +338,6 @@ public BrokerService(PulsarService pulsar, EventLoopGroup eventLoopGroup) throws
         this.clock = pulsar.getClock();
         this.dynamicConfigurationMap = prepareDynamicConfigurationMap();
         this.brokerPublishRateLimiter = new PublishRateLimiterImpl(pulsar.getMonotonicClock());
-        this.preciseTopicPublishRateLimitingEnable =
-                pulsar.getConfiguration().isPreciseTopicPublishRateLimiterEnable();
         this.dispatchRateLimiterFactory = createDispatchRateLimiterFactory(pulsar.getConfig());
         this.managedLedgerStorage = pulsar.getManagedLedgerStorage();
         this.keepAliveIntervalSeconds = pulsar.getConfiguration().getKeepAliveIntervalSeconds();

pulsar-broker/src/test/java/org/apache/pulsar/broker/service/TopicPublishRateThrottleTest.java

@@ -47,7 +47,6 @@ protected void cleanup() throws Exception {
     @Test
     public void testProducerBlockedByPrecisTopicPublishRateLimiting() throws Exception {
         PublishRate publishRate = new PublishRate(1,10);
-        conf.setPreciseTopicPublishRateLimiterEnable(true);
         conf.setMaxPendingPublishRequestsPerConnection(0);
         super.baseSetup();
         admin.namespaces().setPublishRate("prop/ns-abc", publishRate);
@@ -93,7 +92,6 @@ public void testSystemTopicPublishNonBlock() throws Exception {
     @Test
     public void testPrecisTopicPublishRateLimitingProduceRefresh() throws Exception {
         PublishRate publishRate = new PublishRate(1,10);
-        conf.setPreciseTopicPublishRateLimiterEnable(true);
         conf.setMaxPendingPublishRequestsPerConnection(0);
         super.baseSetup();
         admin.namespaces().setPublishRate("prop/ns-abc", publishRate);
@@ -129,7 +127,6 @@ public void testPrecisTopicPublishRateLimitingProduceRefresh() throws Exception
 
     @Test
     public void testBrokerLevelPublishRateDynamicUpdate() throws Exception{
-        conf.setPreciseTopicPublishRateLimiterEnable(true);
         conf.setMaxPendingPublishRequestsPerConnection(0);
         super.baseSetup();
         final String topic = "persistent://prop/ns-abc/testMultiLevelPublishRate";