fixes to use different secrets, show the results in the log

[msciabarra]

Changes to run without errors.

Description

My github actions pass the AWS_ACCESS_ID secrets to the build but since they are pull requests they are empty.

This enables some tests usually skipped that fails. So I changed the name of the variables used to upload logs.
Furthermore I made optional the upload of logs and slack notification and printed the results of the test in the job run for inspection.

Now all tests pass.

Build fails because of overlap of env variables

Related issue and scope

• I opened an issue to propose and discuss this change (#????)

My changes affect the following components

• API
• Controller
• Message Bus (e.g., Kafka)
• Loadbalancer
• Scheduler
• Invoker
• Intrinsic actions (e.g., sequences, conductors)
• Data stores (e.g., CouchDB)
• Tests
• Deployment
• CLI
• General tooling
• Documentation

Types of changes

• Bug fix (generally a non-breaking change which closes an issue).
• Enhancement or new feature (adds new functionality).
• Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

• I signed an Apache CLA.
• I reviewed the style guides and followed the recommendations (Travis CI will check :).
• I added tests to cover my changes.
• My changes require further changes to the documentation.
• I updated the documentation where necessary.

[codecov-commenter]

Codecov Report

Merging #5367 (bc7c65b) into master (f717619) will decrease coverage by 52.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #5367       +/-   ##
==========================================
- Coverage   57.37%   4.52%   -52.86%     
==========================================
  Files         233     240        +7     
  Lines       14143   14407      +264     
  Branches      597     601        +4     
==========================================
- Hits         8115     652     -7463     
- Misses       6028   13755     +7727     

Impacted Files	Coverage Δ
.../main/scala/org/apache/openwhisk/core/WarmUp.scala	0.00% <0.00%> (-100.00%)	⬇️
...ain/scala/org/apache/openwhisk/spi/SpiLoader.scala	0.00% <0.00%> (-100.00%)	⬇️
...scala/org/apache/openwhisk/common/time/Clock.scala	0.00% <0.00%> (-100.00%)	⬇️
...scala/org/apache/openwhisk/core/FeatureFlags.scala	0.00% <0.00%> (-100.00%)	⬇️
...scala/org/apache/openwhisk/http/CorsSettings.scala	0.00% <0.00%> (-100.00%)	⬇️
...la/org/apache/openwhisk/http/BasicRasService.scala	0.00% <0.00%> (-100.00%)	⬇️
...pache/openwhisk/http/LenientSprayJsonSupport.scala	0.00% <0.00%> (-100.00%)	⬇️
...ache/openwhisk/core/database/DocumentFactory.scala	0.00% <0.00%> (-100.00%)	⬇️
.../apache/openwhisk/core/controller/Namespaces.scala	0.00% <0.00%> (-100.00%)	⬇️
...che/openwhisk/core/invoker/LogStoreCollector.scala	0.00% <0.00%> (-100.00%)	⬇️
... and 155 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sciabarracom]

My github actions pass the AWS_ACCESS_ID secrets to the build but since they are pull requests they are empty. This enables some tests and make some of them fail. So I changed the name of the variables used to upload logs. Furthermore I made optional the upload of logs and slack notification and printed the results of the tes in the job run for inspection. Now all test pass.

[style95]

BTW, if we change the variable, how can we test the S3 uploading tests?

[sciabarracom]

BTW, if we change the variable, how can we test the S3 uploading tests?

we cannot test it anyway and they are not tested with travis - secrets are not passed to pull requests (otherwise it would be trivial to grab them, just make a pull request that dumps and writes them somewhere)

you can test them only locally and if you have all the expected environment variables, what I did wrong was to use the environment variables that activated the tests

[msciabarra]

This is odd... when I remove the AWS variables this test starts to fail...
If I enable them it will be the S3StorageTest to fail
I need to figure out why.