Skip to content

Commit bc7c65b

Browse files
propagating aws variabales and disabiling a test if the key is there ut empty
1 parent 7309bdf commit bc7c65b

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

.github/workflows/1-unit.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,11 @@ env:
3939
LOG_SECRET_ACCESS_KEY: ${{ secrets.LOG_SECRET_ACCESS_KEY }}
4040
LOG_REGION: ${{ secrets.LOG_REGION }}
4141

42+
# some tests need also this even if they are empty on pull_requests...
43+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
44+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
45+
AWS_REGION: ${{ secrets.AWS_REGION }}
46+
4247
# github
4348
GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
4449
GH_BRANCH: ${{ github.head_ref || github.ref_name }}

tests/src/test/scala/org/apache/openwhisk/core/database/s3/S3Aws.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ trait S3Aws extends FlatSpec {
5757

5858
override protected def withFixture(test: NoArgTest) = {
5959
assume(
60-
secretAccessKey != null,
60+
secretAccessKey != null && secretAccessKey != "",
6161
"'AWS_SECRET_ACCESS_KEY' env not configured. Configure following " +
6262
"env variables for test to run. 'AWS_ACCESS_KEY_ID', 'AWS_SECRET_ACCESS_KEY', 'AWS_REGION'")
6363

0 commit comments

Comments
 (0)