Skip to content

Use testcontainers to test MongoDB stuff #5234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jiangpengcheng
Copy link
Contributor

Description

Use testcontainers for testing mongodb just like elasticsearch, hope this can fix cron build error of master too

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #5234 (8bcbad0) into master (37f1f99) will increase coverage by 36.99%.
The diff coverage is 40.00%.

@@             Coverage Diff             @@
##           master    #5234       +/-   ##
===========================================
+ Coverage   26.29%   63.29%   +36.99%     
===========================================
  Files         238      238               
  Lines       13965    13965               
  Branches      576      578        +2     
===========================================
+ Hits         3672     8839     +5167     
+ Misses      10293     5126     -5167     
Impacted Files Coverage Δ
...whisk/connector/kafka/KafkaProducerConnector.scala 26.82% <0.00%> (-33.18%) ⬇️
...apache/openwhisk/connector/lean/LeanProducer.scala 0.00% <0.00%> (ø)
.../org/apache/openwhisk/core/connector/Message.scala 65.97% <ø> (+23.71%) ⬆️
.../openwhisk/core/loadBalancer/FPCPoolBalancer.scala 0.00% <0.00%> (ø)
...enwhisk/core/loadBalancer/InvokerSupervision.scala 90.27% <0.00%> (+90.27%) ⬆️
...e/loadBalancer/ShardingContainerPoolBalancer.scala 78.53% <ø> (+78.53%) ⬆️
...ontainerpool/v2/FunctionPullingContainerPool.scala 80.32% <ø> (+80.32%) ⬆️
...nwhisk/core/invoker/ContainerMessageConsumer.scala 78.72% <ø> (+78.72%) ⬆️
...he/openwhisk/core/invoker/FPCInvokerReactive.scala 0.00% <ø> (ø)
...sk/core/scheduler/container/ContainerManager.scala 0.00% <0.00%> (ø)
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbdcfe5...8bcbad0. Read the comment docs.

@ningyougang
Copy link
Contributor

LGTM

@jiangpengcheng jiangpengcheng merged commit 674704e into apache:master May 17, 2022
JesseStutler pushed a commit to JesseStutler/openwhisk that referenced this pull request Jul 13, 2022
* Use testcontainers to test MongoDB stuff

* Use compile in gradle for consistency

* Add google repositories

* checking

* Recreate client when config is changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants