Use testcontainers to test MongoDB stuff (#5234)

* Use testcontainers to test MongoDB stuff

* Use compile in gradle for consistency

* Add google repositories

* checking

* Recreate client when config is changed

Author: jiangpengcheng

build.gradle

@@ -17,6 +17,7 @@
 
 buildscript {
     repositories {
+        google()
         jcenter()
     }
     dependencies {

common/scala/src/main/scala/org/apache/openwhisk/core/database/mongodb/MongoDBArtifactStoreProvider.scala

@@ -37,13 +37,16 @@ case class MongoDBConfig(uri: String, database: String) {
 }
 
 object MongoDBClient {
-  private var _client: Option[MongoClient] = None
+  private var _clientWithConfig: Option[(MongoClient, MongoDBConfig)] = None
 
   def client(config: MongoDBConfig): MongoClient = {
-    _client.getOrElse {
-      val client = MongoClient(config.uri)
-      _client = Some(client)
-      client
+    _clientWithConfig match {
+      case Some((client, oldConfig)) if oldConfig == config =>
+        client
+      case _ =>
+        val client = MongoClient(config.uri)
+        _clientWithConfig = Some(client, config)
+        client
     }
   }
 }

tests/build.gradle

@@ -230,7 +230,8 @@ dependencies {
     compile "io.fabric8:kubernetes-server-mock:${gradle.kube_client.version}"
 
     compile "com.amazonaws:aws-java-sdk-s3:1.11.295"
-    compile "org.testcontainers:elasticsearch:1.15.3"
+    compile 'org.testcontainers:elasticsearch:1.17.1'
+    compile 'org.testcontainers:mongodb:1.17.1'
 
     compile project(':common:scala')
     compile project(':core:controller')

tests/src/test/resources/application.conf.j2

@@ -71,8 +71,7 @@ whisk {
     }
 
     mongodb {
-        uri         = ${?MONGODB_CONNECT_STRING}
-        database    = ${?MONGODB_DATABASE}
+        docker-image = "{{ 'mongo:' ~ mongodb.version }}"
     }
 
     controller {

tests/src/test/scala/org/apache/openwhisk/core/database/mongodb/MongoDBStoreBehaviorBase.scala

@@ -17,31 +17,37 @@
 
 package org.apache.openwhisk.core.database.mongodb
 
-import org.apache.openwhisk.core.ConfigKeys
 import org.apache.openwhisk.core.database.test.behavior.ArtifactStoreBehaviorBase
 import org.apache.openwhisk.core.database.{ArtifactStore, AttachmentStore, DocumentSerializer}
 import org.apache.openwhisk.core.entity._
 import org.scalatest.FlatSpec
+import org.testcontainers.containers.MongoDBContainer
 import pureconfig.loadConfigOrThrow
 import pureconfig.generic.auto._
 
-import scala.reflect.{classTag, ClassTag}
-import scala.util.Try
+import scala.reflect.{ClassTag, classTag}
 
 trait MongoDBStoreBehaviorBase extends FlatSpec with ArtifactStoreBehaviorBase {
-  override def storeType = "MongoDB"
+  val imageName = loadConfigOrThrow[String]("whisk.mongodb.docker-image")
+  val container = new MongoDBContainer(imageName)
+  container.start()
+
+  override def afterAll = {
+    container.close()
+    super.afterAll()
+  }
 
-  override lazy val storeAvailableCheck: Try[Any] = storeConfigTry
+  override def storeType = "MongoDB"
 
-  val storeConfigTry = Try { loadConfigOrThrow[MongoDBConfig](ConfigKeys.mongodb) }
+  val storeConfig = MongoDBConfig(container.getReplicaSetUrl, "unittest")
 
   override lazy val authStore = {
     implicit val docReader: DocumentReader = WhiskDocumentReader
-    MongoDBArtifactStoreProvider.makeArtifactStore[WhiskAuth](storeConfigTry.get, getAttachmentStore[WhiskAuth]())
+    MongoDBArtifactStoreProvider.makeArtifactStore[WhiskAuth](storeConfig, getAttachmentStore[WhiskAuth]())
   }
 
   override lazy val entityStore =
-    MongoDBArtifactStoreProvider.makeArtifactStore[WhiskEntity](storeConfigTry.get, getAttachmentStore[WhiskEntity]())(
+    MongoDBArtifactStoreProvider.makeArtifactStore[WhiskEntity](storeConfig, getAttachmentStore[WhiskEntity]())(
       classTag[WhiskEntity],
       WhiskEntityJsonFormat,
       WhiskDocumentReader,
@@ -51,7 +57,7 @@ trait MongoDBStoreBehaviorBase extends FlatSpec with ArtifactStoreBehaviorBase {
   override lazy val activationStore = {
     implicit val docReader: DocumentReader = WhiskDocumentReader
     MongoDBArtifactStoreProvider
-      .makeArtifactStore[WhiskActivation](storeConfigTry.get, getAttachmentStore[WhiskActivation]())
+      .makeArtifactStore[WhiskActivation](storeConfig, getAttachmentStore[WhiskActivation]())
   }
 
   override protected def getAttachmentStore(store: ArtifactStore[_]) =

tests/src/test/scala/org/apache/openwhisk/core/scheduler/grpc/test/ActivationServiceImplTests.scala

@@ -64,6 +64,8 @@ class ActivationServiceImplTests
 
   private def await[T](awaitable: Future[T], timeout: FiniteDuration = 10.seconds) = Await.result(awaitable, timeout)
 
+  implicit val timeoutConfig = PatienceConfig(5.seconds)
+
   behavior of "ActivationService"
 
   implicit val ec = system.dispatcher