Skip to content

Add fpc pool balancer #5191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

style95
Copy link
Member

@style95 style95 commented Jan 5, 2022

Description

This is to add FPCPoolBalancer
I opened a new PR to see if there is any difference in the Travis CI environment.
Old one: #5158

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #5191 (5e479a3) into master (9633043) will increase coverage by 29.04%.
The diff coverage is 34.58%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5191       +/-   ##
===========================================
+ Coverage   45.50%   74.54%   +29.04%     
===========================================
  Files         234      235        +1     
  Lines       13389    13654      +265     
  Branches      551      545        -6     
===========================================
+ Hits         6092    10179     +4087     
+ Misses       7297     3475     -3822     
Impacted Files Coverage Δ
...rg/apache/openwhisk/common/AverageRingBuffer.scala 27.27% <ø> (ø)
...che/openwhisk/core/loadBalancer/LoadBalancer.scala 81.81% <0.00%> (+81.81%) ⬆️
...e/loadBalancer/ShardingContainerPoolBalancer.scala 78.53% <ø> (+78.53%) ⬆️
...e/openwhisk/core/scheduler/queue/MemoryQueue.scala 83.73% <ø> (ø)
.../openwhisk/core/loadBalancer/FPCPoolBalancer.scala 33.06% <33.06%> (ø)
...enwhisk/core/loadBalancer/CommonLoadBalancer.scala 71.42% <64.28%> (+71.42%) ⬆️
...whisk/connector/kafka/KafkaProducerConnector.scala 60.00% <0.00%> (-27.50%) ⬇️
...nwhisk/core/scheduler/queue/ContainerCounter.scala 84.21% <0.00%> (-7.90%) ⬇️
...pache/openwhisk/core/containerpool/Container.scala 89.65% <0.00%> (-1.15%) ⬇️
...ntainerpool/v2/FunctionPullingContainerProxy.scala 78.12% <0.00%> (+0.34%) ⬆️
... and 136 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9633043...5e479a3. Read the comment docs.

@style95
Copy link
Member Author

style95 commented Jan 6, 2022

superseded by #5192

@style95 style95 closed this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants