[New Scheduler] Add FPCPoolBalancer #5158
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5158 +/- ##
==========================================
- Coverage 45.50% 41.72% -3.78%
==========================================
Files 234 235 +1
Lines 13389 13655 +266
Branches 551 546 -5
==========================================
- Hits 6092 5698 -394
- Misses 7297 7957 +660
Continue to review full report at Codecov.
|
|
I found the environment variable for unit tests is not properly exported. So some tests which is excluded from unit tests are being executed. |
|
Getting this from the performance tests. |
|
It seems during the performance tests, connection errors against runtime containers are happening. |
|
I suspect the Travis VM cannot handle the docker workload for some reason. |
|
I found a small portion of tests were already being failed in another test even if it is marked as $ TERM=dumb ./tests/performance/wrk_tests/throughput.sh "https://172.17.0.1:10001" "$(cat ansible/files/auth.guest)" ./tests/performance/preparation/actions/async.js 100 110 2 2m
Creating action async_110
{"annotations":[{"key":"provide-api-key","value":false},{"key":"exec","value":"nodejs:10"}],"exec":{"kind":"nodejs:10","code":"/*\n * Licensed to the Apache Software Foundation (ASF) under one or more\n * contributor license agreements. See the NOTICE file distributed with\n * this work for additional information regarding copyright ownership.\n * The ASF licenses this file to You under the Apache License, Version 2.0\n * (the \"License\"); you may not use this file except in compliance with\n * the License. You may obtain a copy of the License at\n *\n * http://www.apache.org/licenses/LICENSE-2.0\n *\n * Unless required by applicable law or agreed to in writing, software\n * distributed under the License is distributed on an \"AS IS\" BASIS,\n * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n * See the License for the specific language governing permissions and\n * limitations under the License.\n */\n\nfunction main() {\n return new Promise(function (resolve, reject) {\n setTimeout(function () {\n resolve({done: true});\n }, 175);\n })\n}","binary":false},"limits":{"concurrency":110,"logs":10,"memory":256,"timeout":60000},"name":"async_110","namespace":"guest","parameters":[],"publish":false,"updated":1612280953586,"version":"0.0.1"}Running async_110 once to assert an intact system
{"activationId":"83d84193c4414def984193c4418def45","annotations":[{"key":"path","value":"guest/async_110"},{"key":"waitTime","value":1469},{"key":"kind","value":"nodejs:10"},{"key":"timeout","value":false},{"key":"limits","value":{"concurrency":110,"logs":10,"memory":256,"timeout":60000}},{"key":"initTime","value":374}],"duration":555,"end":1612280955799,"logs":[],"name":"async_110","namespace":"guest","publish":false,"response":{"result":{"done":true},"size":13,"status":"success","success":true},"start":1612280955244,"subject":"guest","version":"0.0.1"}Running 2m test @ https://172.17.0.1:10001/api/v1/namespaces/_/actions/async_110?blocking=true
2 threads and 100 connections
Thread Stats Avg Stdev Max +/- Stdev
Latency 610.72ms 332.99ms 6.35s 95.03%
Req/Sec 84.71 58.64 370.00 71.60%
Latency Distribution
50% 560.17ms
75% 671.19ms
90% 801.36ms
99% 1.51s
19156 requests in 2.00m, 17.49MB read
Socket errors: connect 0, read 0, write 0, timeout 16
Non-2xx or 3xx responses: 16
Requests/sec: 159.51
Transfer/sec: 149.11KBhttps://app.travis-ci.com/github/apache/openwhisk/jobs/479539830 Since we are running lots of components and wrk docker client on a VM with 2 cores and 8GB memory, I feel it doesn't have enough resources to run performance tests on it. |
|
I suspect this issue comes to the fore because of the docker version upgrade. https://app.travis-ci.com/github/apache/openwhisk/jobs/479539830 |
style95
force-pushed
the
add-fpc-pool-balancer
branch
from
5defb4b to
7f71e79
Compare
style95
added a commit
to style95/openwhisk
that referenced
this pull request
Jan 4, 2022
style95
commented
Jan 4, 2022
.travis.yml
Outdated
| - OPENWHISK_HOST="172.17.0.1" CONNECTIONS="100" REQUESTS_PER_SEC="1" ./gradlew gatlingRun-org.apache.openwhisk.ApiV1Simulation | ||
| - OPENWHISK_HOST="172.17.0.1" MEAN_RESPONSE_TIME="1000" API_KEY="$(cat ansible/files/auth.guest)" EXCLUDED_KINDS="python:default,java:default,swift:default" PAUSE_BETWEEN_INVOKES="100" ./gradlew gatlingRun-org.apache.openwhisk.LatencySimulation | ||
| - OPENWHISK_HOST="172.17.0.1" API_KEY="$(cat ansible/files/auth.guest)" CONNECTIONS="100" REQUESTS_PER_SEC="1" ./gradlew gatlingRun-org.apache.openwhisk.BlockingInvokeOneActionSimulation | ||
| - OPENWHISK_HOST="172.17.0.1" API_KEY="$(cat ansible/files/auth.guest)" CONNECTIONS="100" REQUESTS_PER_SEC="1" ASYNC="true" ./gradlew gatlingRun-org.apache.openwhisk.BlockingInvokeOneActionSimulation | ||
| # The following configuration does not make much sense. But we do not have enough users. But it's good to verify, that the test is still working. | ||
| - OPENWHISK_HOST="172.17.0.1" USERS="1" REQUESTS_PER_SEC="1" ./gradlew gatlingRun-org.apache.openwhisk.ColdBlockingInvokeSimulation | ||
| - TERM=dumb ./tests/performance/wrk_tests/latency.sh "https://172.17.0.1:10001" "$(cat ansible/files/auth.guest)" ./tests/performance/preparation/actions/noop.js 2m |
There was a problem hiding this comment.
I changed the order to pass the performance test.
But it does not mean the performance test is fully working, still tests with wrk complain about activations with non-2xx,3xx responses.
IMHO, we need a more stable environment to run these tests.
So I opened a new issue, #5190
style95
commented
Jan 4, 2022
.travis.yml
Outdated
| @@ -85,19 +85,20 @@ jobs: | |||
| - ./tools/travis/checkAndUploadLogs.sh standalone | |||
| name: "Standalone Tests" | |||
| - script: | |||
| - sed -i "s@pause-grace = 50 milliseconds@pause-grace = 10 seconds@g" ./core/invoker/src/main/resources/application.conf | |||
There was a problem hiding this comment.
This is to minimize too frequent status changes(PAUSED <-> RUNNING).
It looks the system cannot forward activations to runtime containers in time due to limited resources.
style95
force-pushed
the
add-fpc-pool-balancer
branch
2 times, most recently
from
50bf6a9 to
983c8d2
Compare
style95
force-pushed
the
add-fpc-pool-balancer
branch
from
983c8d2 to
3fdd05a
Compare
This was referenced Jan 5, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to add FPCPoolBalancer
Related issue and scope
My changes affect the following components
Types of changes
Checklist: