Skip to content

fix: add new Windows docker.exe location #4991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Conversation

shazron
Copy link
Member

@shazron shazron commented Oct 6, 2020

See docker/for-win#7898
See adobe/aio-cli-plugin-app#304

Description

The Windows docker.exe location has been changed, so the openwhisk.jar will fail to run since the search locations are hard-coded. This PR adds the new path to the search paths.

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

Check: `./gradlew checkScalaFmt`
Fix: `./gradlew scalaFmt`
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ef55353). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4991   +/-   ##
=========================================
  Coverage          ?   76.31%           
=========================================
  Files             ?      202           
  Lines             ?     9802           
  Branches          ?      400           
=========================================
  Hits              ?     7480           
  Misses            ?     2322           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef55353...66f85aa. Read the comment docs.

@shazron
Copy link
Member Author

shazron commented Oct 7, 2020

The tests pass now (I fixed the Scala formatting).

For reference for others, to fix Scala formatting issues:

./gradlew scalaFmt
# should pass now
./gradlew checkScalaFmt

@rabbah rabbah merged commit fb3220c into apache:master Oct 7, 2020
@shazron shazron deleted the patch-1 branch October 8, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants