Windows: docker not found when running `aio app run --local --verbose` (openwhisk)

[shazron]

On Windows 10, Docker version 19.03.13, build 4484c46d9d, Docker Desktop Community 2.4.0.0

Docker is installed, and the docker checks all pass in our checks in the app plugin.

However, the local Openwhisk stack can't find it, because it is looking for docker in C:\Program Files\Docker\Docker\resources\bin\docker.exe. The .exe location has changed to C:\Program Files\Docker\Docker\resources\docker.exe . See docker/for-win#7898

Log:

C:\Users\shazron\Desktop\tmp\app-1>aio app run --local --verbose
i checking if java is installed...
i checking if docker is installed...
i checking if docker is running...
i starting local OpenWhisk stack..
\ Exception in thread "main" java.lang.reflect.InvocationTargetException
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:564)
        at org.springframework.boot.loader.MainMethodRunner.run(MainMethodRunner.java:47)
        at org.springframework.boot.loader.Launcher.launch(Launcher.java:86)
        at org.springframework.boot.loader.Launcher.launch(Launcher.java:50)
        at org.springframework.boot.loader.JarLauncher.main(JarLauncher.java:51)
Caused by: java.io.FileNotFoundException: Couldn't locate docker binary (tried: /usr/bin/docker, /usr/local/bin/docker, C:\Program Files\Docker\Docker\resources\bin\docker.exe).
        at org.apache.openwhisk.core.containerpool.docker.DockerClient.$anonfun$dockerCmd$3(DockerClient.scala:96)
        at scala.util.Failure.getOrElse(Try.scala:222)
        at org.apache.openwhisk.core.containerpool.docker.DockerClient.<init>(DockerClient.scala:96)
        at org.apache.openwhisk.standalone.StandaloneDockerClient.<init>(StandaloneDockerSupport.scala:203)
        at org.apache.openwhisk.standalone.StandaloneOpenWhisk$.prepareDocker(StandaloneOpenWhisk.scala:420)
        at org.apache.openwhisk.standalone.StandaloneOpenWhisk$.main(StandaloneOpenWhisk.scala:231)
        at org.apache.openwhisk.standalone.StandaloneOpenWhisk.main(StandaloneOpenWhisk.scala)
        ... 8 more
\   @adobe/aio-cli-plugin-app:runDev:error unexpected error, cleaning up...
×
    Error: local openwhisk stack startup timed out: 60000ms

[aiojbot]

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-942

[meryllblanchet]

The path list is defined here https://github.com/apache/openwhisk/blob/master/core/standalone/src/main/scala/org/apache/openwhisk/standalone/StandaloneDockerSupport.scala#L189.

@chetanmeh confirmed we could add another entry to the list.

[shazron]

added a patch apache/openwhisk#4991

[shazron]

patch integrated, we need to build a new jar https://github.com/apache/openwhisk/blob/master/core/standalone/README.md and add it to the our jar download at

aio-cli-plugin-app/src/lib/owlocal.js

Line 47 in db51485

OW_JAR_URL = 'https://dl.bintray.com/adobeio-firefly/aio/openwhisk-standalone.jar',

[shazron]

New PR apache/openwhisk#5021