-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Replace zip/jar artifacts with source. #4763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
79c3e61
to
846eeed
Compare
Removed files which seem to have no references in this repo.
# | ||
|
||
set -e | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obviously this won't work on windows and requires zip
, python
and pip
to be present and java 8.
Codecov Report
@@ Coverage Diff @@
## master #4763 +/- ##
=========================================
- Coverage 84.89% 78.3% -6.59%
=========================================
Files 198 198
Lines 8837 8837
Branches 606 606
=========================================
- Hits 7502 6920 -582
- Misses 1335 1917 +582
Continue to review full report at Codecov.
|
Detect if java 8 is available, and build jar only then.
Will skip test if file doesn't exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that building binary test artifacts works for me on mac
@dgrove-oss ok to merge? once committed, we should move ahead with a release - are we ready? |
@dgrove-oss - i think this broke the openwhisk cli travis... a few of the removed files are used by the cli tests. @steven0711dong fyi |
@mdeuser apache/openwhisk-cli#477 adds the target to build them |
This PR removes zip/jar files that are not referenced in this repo. It may be there are references to them from other repos (I checked some repos but not all). In any case, it makes sense to move any such artifacts to where they are used. For example the python virtual env related zip files are used in the python runtime only as far as I can tell.
For the remaining test artifacts, I committed the sources and a build script to construct the zipped artifacts at setup time.
Description
Related issue and scope
My changes affect the following components
Types of changes
Checklist: