Skip to content

Replace zip/jar artifacts with source. #4763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 17, 2019
Merged

Conversation

rabbah
Copy link
Member

@rabbah rabbah commented Dec 5, 2019

This PR removes zip/jar files that are not referenced in this repo. It may be there are references to them from other repos (I checked some repos but not all). In any case, it makes sense to move any such artifacts to where they are used. For example the python virtual env related zip files are used in the python runtime only as far as I can tell.

For the remaining test artifacts, I committed the sources and a build script to construct the zipped artifacts at setup time.

Description

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@rabbah rabbah force-pushed the testzips branch 3 times, most recently from 79c3e61 to 846eeed Compare December 5, 2019 00:51
Removed files which seem to have no references in this repo.
#

set -e

Copy link
Member Author

@rabbah rabbah Dec 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obviously this won't work on windows and requires zip, python and pip to be present and java 8.

@codecov-io
Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #4763 into master will decrease coverage by 6.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4763      +/-   ##
=========================================
- Coverage   84.89%   78.3%   -6.59%     
=========================================
  Files         198     198              
  Lines        8837    8837              
  Branches      606     606              
=========================================
- Hits         7502    6920     -582     
- Misses       1335    1917     +582
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0% <0%> (-100%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0% <0%> (-100%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0% <0%> (-100%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0% <0%> (-100%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0% <0%> (-96.23%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0% <0%> (-93.85%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0% <0%> (-92.31%) ⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala 0% <0%> (-77.78%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0% <0%> (-74.08%) ⬇️
...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala 7.69% <0%> (-50%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6126a94...9fb673e. Read the comment docs.

Detect if java 8 is available, and build jar only then.
Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that building binary test artifacts works for me on mac

@rabbah
Copy link
Member Author

rabbah commented Dec 17, 2019

@dgrove-oss ok to merge? once committed, we should move ahead with a release - are we ready?

@dgrove-oss dgrove-oss merged commit eb441ff into apache:master Dec 17, 2019
@rabbah rabbah deleted the testzips branch December 18, 2019 13:01
@mdeuser
Copy link
Contributor

mdeuser commented Jan 6, 2020

@dgrove-oss - i think this broke the openwhisk cli travis... a few of the removed files are used by the cli tests.

@steven0711dong fyi

@dgrove-oss
Copy link
Member

@mdeuser apache/openwhisk-cli#477 adds the target to build them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants