Skip to content

build binary test artifacts #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 7, 2020
Merged

build binary test artifacts #477

merged 6 commits into from
Jan 7, 2020

Conversation

dgrove-oss
Copy link
Member

No description provided.

@dgrove-oss
Copy link
Member Author

@mdeuser @steven0711dong -- need to run the task tests:buildArtifacts to generate the binary artifacts

@mdeuser
Copy link
Contributor

mdeuser commented Jan 7, 2020

thanks a lot @dgrove-oss - is the helloJava.jar expected to be generated by that gradle target? i see some java build lines in the build.sh file, but i don't think this .jar is one of the jar files being built.

@dgrove-oss
Copy link
Member Author

The Java artifact will only be generated if there is a Java8 JVM available. Looking at the log, it appears that the JVM on the test VM was Java11 so the jar generation was skipped.

@mdeuser
Copy link
Contributor

mdeuser commented Jan 7, 2020

ugh..

rr.stdout should include regex ("""(?i)whisk API build\s+201.*""")

we're in a new decade! i believe changing 201.* to 20.* should fix one of the failing tests

Test was broken by removal of binary artifacts from core repository.
Since the jar was not actually used anywhere else, it is not built
by core's test:buildArtifacts.
@dgrove-oss dgrove-oss merged commit d8a6735 into apache:master Jan 7, 2020
@dgrove-oss dgrove-oss deleted the nozip branch January 7, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants