feat(bindings/cpp): eliminate indirect pointers by manually managing memory #6147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate indirect pointers by manually managing the memory of returned classes in lib.rs
Which issue does this PR close?
nop.
Rationale for this change
The previous type erasure implementation using unique_ptr introduced an indirection pointer, resulting in additional overhead.
This was previously mentioned in the earlier PR #6041.
What changes are included in this PR?
Box<T>
removes one layer of erasure overhead, transferring memory management of the returned class from the Rust layer to the C++ layer.#include "opendal/opendal.hpp"
better aligns with modern C++ project conventions than#include "opendal.hpp"
)Are there any user-facing changes?
nop.
cc @JackDrogon