-
Notifications
You must be signed in to change notification settings - Fork 596
feat(bindings/cpp) remove lib.rs.h from opendal.hpp #6041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
228d9f4
to
1e76f1d
Compare
A quick question: |
std::string differs from Rust's String: it's a byte container without encoding validation, where size() returns the byte length (length of raw binary data, not character count). |
1e76f1d
to
4dec01f
Compare
Thank you for the explanation. |
4dec01f
to
eaf30a7
Compare
CI failed for:
|
Signed-off-by: Jack Drogon <[email protected]>
Signed-off-by: Jack Drogon <[email protected]>
Signed-off-by: Jack Drogon <[email protected]>
7a9bf42
to
3e78e70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this, @deadlinefen and @JackDrogon!
Which issue does this PR close?
nop, but inspired by the discussion #6035
Rationale for this change
Remove lib.rs.h from opendal.hpp to make the included source files cleaner for users.
What changes are included in this PR?
Are there any user-facing changes?
cc @JackDrogon