Skip to content

feat(services/gcs): implement write returns metadata #5933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2025
Merged

feat(services/gcs): implement write returns metadata #5933

merged 3 commits into from
Apr 4, 2025

Conversation

meteorgan
Copy link
Contributor

Which issue does this PR close?

Part of #5557

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Apr 1, 2025
@meteorgan meteorgan force-pushed the gcs_write_metadata branch from fe6d183 to e666326 Compare April 1, 2025 14:08
@meteorgan
Copy link
Contributor Author

The Etag for the same object differs between the JSON API and XML API ... how can they get away with that ?
GoogleCloudPlatform/gsutil#1192 (comment)

@meteorgan
Copy link
Contributor Author

Ok, I'll skip the metadata returned by CompleteMultipartUploadResult.

@meteorgan
Copy link
Contributor Author

related description in the docs:
https://cloud.google.com/storage/docs/metadata?hl=zh-cn#etags

@Xuanwo
Copy link
Member

Xuanwo commented Apr 2, 2025

I'm speechless at gcs.

@meteorgan meteorgan force-pushed the gcs_write_metadata branch from 17606bf to be29939 Compare April 2, 2025 13:17
@meteorgan meteorgan marked this pull request as ready for review April 2, 2025 13:17
@meteorgan meteorgan requested a review from Xuanwo as a code owner April 2, 2025 13:17
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request services/gcs labels Apr 2, 2025
Xuanwo
Xuanwo approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 4, 2025
@Xuanwo Xuanwo merged commit eb9cedb into main Apr 4, 2025
276 checks passed
@Xuanwo Xuanwo deleted the gcs_write_metadata branch April 4, 2025 04:00
@meteorgan meteorgan mentioned this pull request Apr 4, 2025
Open
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" services/gcs size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteorgan @Xuanwo