add CompleteMultipartUploadResult

Author: meteorgan

core/src/services/gcs/backend.rs

@@ -429,7 +429,7 @@ impl Access for GcsBackend {
         }
 
         let slc = resp.into_body();
-        let m = GcsCore::get_metadata_from_response(path, slc)?;
+        let m = GcsCore::build_metadata_from_object_response(path, slc)?;
 
         Ok(RpStat::new(m))
     }

core/src/services/gcs/core.rs

@@ -647,7 +647,7 @@ impl GcsCore {
         self.send(req).await
     }
 
-    pub fn get_metadata_from_response(path: &str, data: Buffer) -> Result<Metadata> {
+    pub fn build_metadata_from_object_response(path: &str, data: Buffer) -> Result<Metadata> {
         let meta: GetObjectJsonResponse =
             serde_json::from_reader(data.reader()).map_err(new_json_deserialize_error)?;
 
@@ -769,6 +769,16 @@ pub struct CompleteMultipartUploadRequestPart {
     pub etag: String,
 }
 
+/// Response of Complete a multipart upload
+///
+/// refer to: https://cloud.google.com/storage/docs/xml-api/post-object-complete
+#[derive(Default, Debug, Deserialize)]
+#[serde(default, rename_all = "PascalCase")]
+pub struct CompleteMultipartUploadResult {
+    #[serde(rename = "ETag")]
+    pub etag: String,
+}
+
 /// The raw json response returned by [`get`](https://cloud.google.com/storage/docs/json_api/v1/objects/get)
 #[derive(Debug, Default, Deserialize)]
 #[serde(default, rename_all = "camelCase")]
@@ -841,7 +851,7 @@ mod tests {
   }
 }"#;
 
-        let meta = GcsCore::get_metadata_from_response("1.png", content.into())
+        let meta = GcsCore::build_metadata_from_object_response("1.png", content.into())
             .expect("parse metadata should not fail");
 
         assert_eq!(meta.content_length(), 56535);

core/src/services/gcs/writer.rs

@@ -20,9 +20,9 @@ use std::sync::Arc;
 use bytes::Buf;
 use http::StatusCode;
 
-use super::core::CompleteMultipartUploadRequestPart;
 use super::core::GcsCore;
 use super::core::InitiateMultipartUploadResult;
+use super::core::{CompleteMultipartUploadRequestPart, CompleteMultipartUploadResult};
 use super::error::parse_error;
 use crate::raw::*;
 use crate::*;
@@ -63,7 +63,8 @@ impl oio::MultipartWrite for GcsWriter {
 
         match status {
             StatusCode::CREATED | StatusCode::OK => {
-                let metadata = GcsCore::get_metadata_from_response(&self.path, resp.into_body())?;
+                let metadata =
+                    GcsCore::build_metadata_from_object_response(&self.path, resp.into_body())?;
                 Ok(metadata)
             }
             _ => Err(parse_error(resp)),
@@ -142,7 +143,11 @@ impl oio::MultipartWrite for GcsWriter {
         if !resp.status().is_success() {
             return Err(parse_error(resp));
         }
-        let metadata = GcsCore::get_metadata_from_response(&self.path, resp.into_body())?;
+        let data: CompleteMultipartUploadResult =
+            quick_xml::de::from_reader(resp.into_body().reader())
+                .map_err(new_xml_deserialize_error)?;
+        let mut metadata = Metadata::new(EntryMode::from_path(&self.path));
+        metadata.set_etag(&data.etag);
         Ok(metadata)
     }