Skip to content

MINOR: Improve share coordinator record schemas #19830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

MINOR: Improve share coordinator record schemas #19830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions share-coordinator/src/main/resources/common/message/ShareSnapshotKey.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// KIP-932 is in development. This schema is subject to non-backwards-compatible changes.

{
"apiKey": 0,
"type": "coordinator-key",
Expand Down
20 changes: 9 additions & 11 deletions share-coordinator/src/main/resources/common/message/ShareSnapshotValue.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,36 +13,34 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// KIP-932 is in development. This schema is subject to non-backwards-compatible changes.

{
"apiKey": 0,
"type": "coordinator-value",
"name": "ShareSnapshotValue",
"validVersions": "0",
"flexibleVersions": "0+",
"fields": [
{ "name": "SnapshotEpoch", "type": "uint16", "versions": "0",
{ "name": "SnapshotEpoch", "type": "uint16", "versions": "0+",
"about": "The snapshot epoch." },
{ "name": "StateEpoch", "type": "int32", "versions": "0+",
"about": "The state epoch for this share-partition." },
{ "name": "LeaderEpoch", "type": "int32", "versions": "0+",
"about": "The leader epoch of the share-partition." },
{ "name": "StartOffset", "type": "int64", "versions": "0",
{ "name": "StartOffset", "type": "int64", "versions": "0+",
"about": "The share-partition start offset." },
{ "name": "CreateTimestamp", "type": "int64", "versions": "0",
{ "name": "CreateTimestamp", "type": "int64", "versions": "0+",
"about": "The time at which the state was created." },
{ "name": "WriteTimestamp", "type": "int64", "versions": "0",
{ "name": "WriteTimestamp", "type": "int64", "versions": "0+",
"about": "The time at which the state was written or rewritten." },
{ "name": "StateBatches", "type": "[]StateBatch", "versions": "0",
{ "name": "StateBatches", "type": "[]StateBatch", "versions": "0+",
"about": "The state batches.", "fields": [
{ "name": "FirstOffset", "type": "int64", "versions": "0",
{ "name": "FirstOffset", "type": "int64", "versions": "0+",
"about": "The first offset of this state batch." },
{ "name": "LastOffset", "type": "int64", "versions": "0",
{ "name": "LastOffset", "type": "int64", "versions": "0+",
"about": "The last offset of this state batch." },
{ "name": "DeliveryState", "type": "int8", "versions": "0",
{ "name": "DeliveryState", "type": "int8", "versions": "0+",
"about": "The delivery state - 0:Available,2:Acked,4:Archived." },
{ "name": "DeliveryCount", "type": "int16", "versions": "0",
{ "name": "DeliveryCount", "type": "int16", "versions": "0+",
"about": "The delivery count." }
]}
]
Expand Down
2 changes: 0 additions & 2 deletions share-coordinator/src/main/resources/common/message/ShareUpdateKey.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// KIP-932 is in development. This schema is subject to non-backwards-compatible changes.

{
"apiKey": 1,
"type": "coordinator-key",
Expand Down
16 changes: 7 additions & 9 deletions share-coordinator/src/main/resources/common/message/ShareUpdateValue.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,30 +13,28 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// KIP-932 is in development. This schema is subject to non-backwards-compatible changes.

{
"apiKey": 1,
"type": "coordinator-value",
"name": "ShareUpdateValue",
"validVersions": "0",
"flexibleVersions": "0+",
"fields": [
{ "name": "SnapshotEpoch", "type": "uint16", "versions": "0",
{ "name": "SnapshotEpoch", "type": "uint16", "versions": "0+",
"about": "The snapshot epoch." },
{ "name": "LeaderEpoch", "type": "int32", "versions": "0+",
"about": "The leader epoch of the share-partition." },
{ "name": "StartOffset", "type": "int64", "versions": "0",
{ "name": "StartOffset", "type": "int64", "versions": "0+",
"about": "The share-partition start offset, or -1 if the start offset is not being updated." },
{ "name": "StateBatches", "type": "[]StateBatch", "versions": "0",
{ "name": "StateBatches", "type": "[]StateBatch", "versions": "0+",
"about": "The state batches that have been updated.", "fields": [
{ "name": "FirstOffset", "type": "int64", "versions": "0",
{ "name": "FirstOffset", "type": "int64", "versions": "0+",
"about": "The first offset of this state batch." },
{ "name": "LastOffset", "type": "int64", "versions": "0",
{ "name": "LastOffset", "type": "int64", "versions": "0+",
"about": "The last offset of this state batch." },
{ "name": "DeliveryState", "type": "int8", "versions": "0",
{ "name": "DeliveryState", "type": "int8", "versions": "0+",
"about": "The delivery state - 0:Available,2:Acked,4:Archived." },
{ "name": "DeliveryCount", "type": "int16", "versions": "0",
{ "name": "DeliveryCount", "type": "int16", "versions": "0+",
"about": "The delivery count." }
]}
]
Expand Down