Skip to content

MINOR: Improve share coordinator record schemas #19830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

MINOR: Improve share coordinator record schemas #19830

merged 1 commit into from
May 28, 2025

Conversation

AndrewJSchofield
Copy link
Member

@AndrewJSchofield AndrewJSchofield commented May 27, 2025 •
edited by github-actions bot
Loading

This PR makes some very small improvements to the record schemas for the
share coordinator.

  • It removes the health warnings about incompatible changes. All changes
    are compatible now.
  • It marks the fields in the values as version 0+, in common with all
    other record schemas in Kafka.
    Many were already 0+, so this just corrects the outliers.

Reviewers: Apoorv Mittal [email protected], Sushant Mahajan
[email protected]

@github-actions github-actions bot added KIP-932 Queues for Kafka small Small PRs labels May 27, 2025
@AndrewJSchofield AndrewJSchofield requested a review from smjn May 27, 2025 14:56
apoorvmittal10
apoorvmittal10 approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@apoorvmittal10 apoorvmittal10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

smjn
smjn approved these changes May 28, 2025
View reviewed changes
Copy link
Collaborator

@smjn smjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the PR

@AndrewJSchofield AndrewJSchofield merged commit 5a607db into apache:trunk May 28, 2025
26 checks passed
@AndrewJSchofield AndrewJSchofield deleted the share-coordinator-records branch May 28, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smjn smjn smjn approved these changes

@apoorvmittal10 apoorvmittal10 apoorvmittal10 approved these changes

Assignees
No one assigned
Labels
ci-approved KIP-932 Queues for Kafka small Small PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewJSchofield @smjn @apoorvmittal10