[incubator-kie-issues#2021] DMN boxed filter behavior in relation to implicit conversions

[ChinchuAjith]

Fixes apache/incubator-kie-issues#2021

This PR corrects the behavior of the DMN boxed filter with respect to implicit conversions.

[kie-ci3]

PR job #3 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6393 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6393/3/display/redirect

Test results:

• PASSED: 23656
• FAILED: 1

Those are the test failures:

org.kie.dmn.validation.ValidatorTest.validateAllValidSharedModels

Expecting empty but was: [Message [id=0, level=WARNING, path=valid_models/DMNv1_6/BoxedExpressions.dmn, line=30, column=-1
text=DMN: Variable named 'boxedFilter' is missing its type reference on node 'boxedFilter' (DMN id: _F2C7743C-F89C-42D1-89DA-689DFF6E11DA, Type ref not defined) ],
Message [id=0, level=WARNING, path=valid_models/DMNv1_6/BoxedExpressions.dmn, line=36, column=-1
text=DMN: Variable named 'boxedIterator' is missing its type reference on node 'boxedIterator' (DMN id: _CABFAFAB-3829-46C9-9584-EF093B904CBA, Type ref not defined) ]]

[Copilot]

Pull Request Overview

This PR fixes the behavior of DMN boxed filter operations in relation to implicit conversions, addressing issue #2021. The primary changes include correcting list type handling in the type registry and adding comprehensive test coverage for boxed filter and iterator operations.

• Fixes list type collection flag in DMN type registry from false to true
• Adds new test models for boxed filter and iterator operations
• Implements comprehensive test coverage including edge cases and error scenarios

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
BoxedIterator.dmn	DMN test model for boxed iterator operations with single number input
BoxedFilter.dmn	DMN test model for boxed filter operations with string comparison
DMNTypeRegistryAbstractTest.java	Unit tests for type registry functionality and built-in type handling
DMNRuntimeTest.java	Integration tests for boxed filter/iterator scenarios including error cases
DMNTypeRegistryAbstract.java	Core fix for list type collection flag and refactored type management

Comments suppressed due to low confidence (2)

kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/DMNRuntimeTest.java:529

• The test method name 'boxedFilterInvalidConditionWithInvalidInput' is misleading as it actually tests a boxed iterator, not a boxed filter. Consider renaming to 'boxedIteratorWithInvalidInput'.

    void boxedFilterInvalidConditionWithInvalidInput(boolean useExecModelCompiler) {

kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/DMNRuntimeTest.java:551

• The test method name 'boxedFilterInvalidConditionWithNonNumeric' is misleading as it actually tests a boxed iterator, not a boxed filter. Consider renaming to 'boxedIteratorWithNonNumericInput'.

    void boxedFilterInvalidConditionWithNonNumeric(boolean useExecModelCompiler) {