Skip to content

CB-12361 : added unit-tests for getPlatformDetailsFromDir #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions spec/cordova/platform/getPlatformDetailsFromDir.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
/**
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
*/

var path = require('path');
var fs = require('fs');
var Q = require('q');
var rewire = require('rewire');
var cordova_util = require('../../../src/cordova/util');
var platform_getPlatformDetails = rewire('../../../src/cordova/platform/getPlatformDetailsFromDir');
var events = require('cordova-common').events;
var fail;

describe('cordova/platform/getPlatformDetailsFromDir', function () {
var package_json_mock;
package_json_mock = jasmine.createSpyObj('package json mock', ['cordova', 'dependencies']);
package_json_mock.name = 'io.cordova.hellocordova';
package_json_mock.version = '1.0.0';

beforeEach(function () {
spyOn(Q, 'reject');
spyOn(fs, 'existsSync');
spyOn(cordova_util, 'requireNoCache');
spyOn(events, 'emit');
});

it('should throw if no config.xml or pkgJson', function (done) {
platform_getPlatformDetails('dir', ['ios']);
expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does not seem to contain a valid package.json or a valid Cordova platform/));
done();
});

it('should throw if no platform is provided', function (done) {
cordova_util.requireNoCache.and.returnValue({});
platform_getPlatformDetails('dir');
expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does not seem to contain a Cordova platform:/));
done();
});

it('should return a promise with platform and version', function (done) {
fs.existsSync.and.callFake(function(filePath) {
if(path.basename(filePath) === 'package.json') {
return true;
} else {
return false;
}
});
cordova_util.requireNoCache.and.returnValue(package_json_mock);
platform_getPlatformDetails('dir', ['cordova-android'])
.then(function(result) {
expect(result.platform).toBe('io.cordova.hellocordova');
expect(result.version).toBe('1.0.0');
expect(Q.reject).not.toHaveBeenCalled();
}).fail(function (err) {
fail('unexpected failure handler invoked!');
console.error(err);
}).done(done);
});

it('should remove the cordova- prefix from the platform name for known platforms', function (done) {
expect(platform_getPlatformDetails.platformFromName('cordova-ios')).toBe('ios');
expect(events.emit).toHaveBeenCalledWith('verbose', jasmine.stringMatching(/Removing "cordova-" prefix/));
done();
});
});