CB-12361 : added unit-tests for getPlatformDetailsFromDir #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengill
suggested changes
Jul 27, 2017
| it('should remove the cordova- prefix from the platform name for known platforms', function (done) { | ||
| platform_getPlatformDetails.platformFromName('cordova-ios'); | ||
| expect(events.emit).toHaveBeenCalledWith('verbose', jasmine.stringMatching(/Removing "cordova-" prefix/)); | ||
| expect(platform_getPlatformDetails.platformFromName('cordova-ios')).toBe('ios'); |
There was a problem hiding this comment.
You can take the expect from line 76 and combine it with line 74 and delete 76. So line 74 gets replaced by line 76. Line 75 should still pass
There was a problem hiding this comment.
ohh okay do you mean just like this? @stevengill
it('should remove the cordova- prefix from the platform name for known platforms', function (done) {
expect(platform_getPlatformDetails.platformFromName('cordova-ios')).toBe('ios');
expect(events.emit).toHaveBeenCalledWith('verbose', jasmine.stringMatching(/Removing "cordova-" prefix/));
done();
});
dpogue
pushed a commit
that referenced
this pull request
Oct 23, 2024
…n removePluginFromPlatform() (#913) * plugin/remove.js: don't stomp opts.cli_variables in removePluginFromPlatform() * undo change to line spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
What does this PR do?
added unit-tests for getPlatformDetailsFromDir
What testing has been done on this change?
Checklist