chore: reduce waste in port allocations of some tests #7456
Conversation
alexpyattaev
changed the title
| for _ in 0..MAX_PORT_VERIFY_THREADS * 2 { | ||
| let port_range = unique_port_range_for_tests(1); |
There was a problem hiding this comment.
wonder if in the future, we could release these port ranges and reuse them...
There was a problem hiding this comment.
we are reusing them already! just not within the same process, only with next test.
There was a problem hiding this comment.
ohhhh got it. misunderstood the next test setup
| let (_server_port, (_, server_tcp_listener)) = | ||
| bind_common_in_range_with_config(ip_addr, (2200, 2300), config).unwrap(); | ||
| bind_common_in_range_with_config(ip_addr, (port_range.start, port_range.end), config) |
There was a problem hiding this comment.
so this function is deprecated. should we move these tests over to net-utils/src/sockets.rs?
There was a problem hiding this comment.
I'll make another PR to axe the deprecated functions.
| (2300, 2300 + (MAX_PORT_VERIFY_THREADS * 3) as u16), | ||
| (port_range.start, port_range.end), |
There was a problem hiding this comment.
aren't we kind of defeating the purpose of this test if our port range is 1?
There was a problem hiding this comment.
The allocation of ports is not what we are testing here, this is testing the verification that they are reachable.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7456 +/- ##
=========================================
- Coverage 83.3% 83.3% -0.1%
=========================================
Files 800 800
Lines 362783 362796 +13
=========================================
- Hits 302227 302222 -5
- Misses 60556 60574 +18 🚀 New features to boost your workflow:
|
Problem
Certain test use too many ports so we can get out-of-ports issues in CI.
This is especially a problem since we want to allocate more ports for main validator allocations as in #7455
Summary of Changes
Tame their appetite for ports a bit
This does not change any logic.