fix client side binds in TPU #7455
Merged
+18
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7455 +/- ##
=========================================
- Coverage 83.3% 83.2% -0.1%
=========================================
Files 800 800
Lines 362783 362784 +1
=========================================
- Hits 302227 302153 -74
- Misses 60556 60631 +75 🚀 New features to boost your workflow:
|
gregcusack
reviewed
Aug 11, 2025
gossip/src/node.rs
Outdated
| @@ -203,12 +202,15 @@ impl Node { | |||
| bind_in_range_with_config(bind_ip_addr, port_range, socket_config) | |||
| .expect("Alpenglow port bind should succeed"); | |||
| // These are client sockets, so the port is set to be 0 because it must be ephimeral. | |||
There was a problem hiding this comment.
can you update this comment to match the new behavior please
CHANGELOG.md
Outdated
| @@ -40,6 +40,7 @@ Release channels have their own copy of this changelog: | |||
| * `--skip-poh-verify` | |||
| * Deprecated snapshot archive formats have been removed and are no longer loadable. | |||
| * Using `--snapshot-interval-slots 0` to disable generating snapshots has been removed. Use `--no-snapshots` instead. | |||
| * Validator will now bind all ports within provided `--dynamic-port-range`, a minimum of 25 ports are required. | |||
There was a problem hiding this comment.
is 25 enforced in the actual code for --dynamic-port-range?
There was a problem hiding this comment.
no, but it will actually allocate up to 23 ports, 25 is a safe number to avoid confusion =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CI is flaking due to "bug" in port assignment in
fn new_with_external_ipThis should go in together with #7456 else we can randomly run out of ports in some CI runs.
Summary of Changes