Skip to content

SPL: Use token-2022-interface crate #7298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

joncinque
Copy link

Problem

As outlined in #7256, we need to get Agave off of crates that depend back on Agave.

spl-token-2022 is one of those crates

Summary of changes

Use spl-token-2022-interface instead. To go with this, we had to also upgrade to confidential-transfer-proof-extract v0.4.0, which requires modifications to some tests.

Everything should be very straightforward otherwise, and we get to see some red lines in the lockfile!

#### Problem

As outlined in solana-labs#7256, we need to get Agave off of crates that depend
back on Agave.

spl-token-2022 is one of those crates

#### Summary of changes

Use spl-token-2022-interface instead. To go with this, we had to also
upgrade to confidential-transfer-proof-extract v0.4.0, which requires
modifications to some tests.

Everything should be very straightforward otherwise, and we get to see
some red lines in the lockfile!
@joncinque joncinque requested a review from samkim-crypto August 4, 2025 17:31
@joncinque joncinque requested a review from a team as a code owner August 4, 2025 17:31
Copy link

mergify bot commented Aug 4, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @joncinque.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 97.60000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.0%. Comparing base (3297ff4) to head (0d72cea).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7298     +/-   ##
=========================================
+ Coverage    82.8%    83.0%   +0.1%     
=========================================
  Files         801      801             
  Lines      363392   362352   -1040     
=========================================
- Hits       301027   300889    -138     
+ Misses      62365    61463    -902     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@samkim-crypto samkim-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me!

@joncinque joncinque merged commit c1ce9db into anza-xyz:master Aug 5, 2025
52 checks passed
@joncinque joncinque deleted the tk22-interface branch August 5, 2025 09:55
@joncinque joncinque mentioned this pull request Aug 5, 2025
joncinque added a commit that referenced this pull request Aug 5, 2025
#### Problem

After #7291 landed, #7298 didn't mention any conflicts. However, since
the first one migrated away from spl-memo, and so did #7298, there was
an entry not cleaned up between the two PRs.

#### Summary of changes

Remove the unneeded entry for spl-memo in all lockfiles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants