Skip to content

SPL: Use spl-memo-interface crate #7291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

joncinque
Copy link

Problem

As outlined in #7256, we need to get Agave off of crates that depend back on Agave.

spl-memo is one of those crates

Summary of changes

Use spl-memo-interface instead. The only difference is that build_memo takes in a program id, which is used in one test.

@joncinque joncinque requested a review from rustopian August 4, 2025 11:44
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.8%. Comparing base (3297ff4) to head (1385f75).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7291     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         801      801             
  Lines      363392   363408     +16     
=========================================
- Hits       301027   300957     -70     
- Misses      62365    62451     +86     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rustopian
rustopian previously approved these changes Aug 4, 2025
Copy link

@rustopian rustopian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Straightforward.

#### Problem

As outlined in solana-labs#7256, we need to get Agave off of crates that depend
back on Agave.

spl-memo is one of those crates

#### Summary of changes

Use spl-memo-interface instead. The only difference is that `build_memo`
takes in a program id, which is used in one test.
@joncinque
Copy link
Author

Sorry, can I get another approval? Had to rebase after the instruction-padding change went in

@rustopian rustopian self-requested a review August 4, 2025 16:53
Copy link

@rustopian rustopian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. No PR content has changed; relying on CI to confirm everything still passes.

@joncinque joncinque merged commit fb1d632 into anza-xyz:master Aug 4, 2025
52 checks passed
@joncinque joncinque deleted the memo-interface branch August 4, 2025 18:48
@joncinque joncinque mentioned this pull request Aug 5, 2025
joncinque added a commit that referenced this pull request Aug 5, 2025
#### Problem

After #7291 landed, #7298 didn't mention any conflicts. However, since
the first one migrated away from spl-memo, and so did #7298, there was
an entry not cleaned up between the two PRs.

#### Summary of changes

Remove the unneeded entry for spl-memo in all lockfiles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants