Skip to content

refactor: remove ruff ignores F #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2025
Merged

refactor: remove ruff ignores F #506

merged 2 commits into from
Mar 19, 2025

Conversation

StefanThoene
Copy link
Collaborator

@StefanThoene StefanThoene commented Mar 18, 2025 •
edited
Loading

Description

remove ruff ignore for F rules

Issue linked

#478

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@StefanThoene
remove ruff ignores F401
b095a12 
remove ruff ignores F841
add file ignore for __init__.py  for F401
@StefanThoene StefanThoene self-assigned this Mar 18, 2025
@StefanThoene StefanThoene linked an issue Mar 18, 2025 that may be closed by this pull request
remove ruff ignore "F", # pyflakes #478
Closed
@StefanThoene StefanThoene marked this pull request as ready for review March 18, 2025 16:24
@github-actions github-actions bot added maintenance Package and maintenance related testing Anything related to tests labels Mar 18, 2025
@StefanThoene StefanThoene merged commit 3c07d30 into main Mar 19, 2025
27 checks passed
@StefanThoene StefanThoene deleted the refactor/ruff-F branch March 19, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echambla echambla echambla approved these changes

Assignees

@StefanThoene StefanThoene

Labels
maintenance Package and maintenance related testing Anything related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove ruff ignore "F", # pyflakes
3 participants
@StefanThoene @echambla @pyansys-ci-bot