refactor: remove ruff ignores F (#506)

## Description
remove ruff ignore for F rules

## Issue linked
#478 

## Checklist
- [x] I have tested my changes locally.
- [x] I have added necessary documentation or updated existing
documentation.
- [x] I have followed the coding style guidelines of this project.
- [x] I have added appropriate tests (unit, integration, system).
- [x] I have reviewed my changes before submitting this pull request.
- [x] I have linked the issue or issues that are solved by the PR if
any.
- [x] I have assigned this PR to myself.
- [x] I have made sure that the title of my PR follows [Conventional
commits style](https://www.conventionalcommits.org/en/v1.0.0/#summary)
(e.g. ``feat: add optical property``)
- [x] I have agreed with the Contributor License Agreement
([CLA](https://developer.ansys.com/form/cla-acceptance)).

---------

Co-authored-by: pyansys-ci-bot <[email protected]>

Author: StefanThoene

doc/changelog.d/506.miscellaneous.md

@@ -0,0 +1 @@
+remove ruff ignores F

examples/core/source.py

@@ -5,7 +5,6 @@
 # There are different type of sources available: luminaire source, surface source, ray file source.
 
 # +
-import os
 from pathlib import Path
 
 from ansys.speos.core import GeoRef, Project, Speos

examples/kernel/modify-scene.py

@@ -29,7 +29,6 @@
 
 from ansys.api.speos.sensor.v1 import camera_sensor_pb2
 from ansys.speos.core import Speos
-from ansys.speos.core.kernel import SensorTemplateLink
 from ansys.speos.core.kernel.scene import ProtoScene
 from ansys.speos.core.kernel.sensor_template import ProtoSensorTemplate
 

pyproject.toml

@@ -99,8 +99,6 @@ select = [
     "TD",   # flake8-todos, https://docs.astral.sh/ruff/rules/#flake8-todos-td
 ]
 ignore = [
-    "F401",
-    "F841", # TODO: Local variable assigned but never used
     "N802", # TODO: Function name should be lowercase
     "N803",
     "N806",
@@ -113,6 +111,7 @@ ignore = [
 
 [tool.ruff.lint.per-file-ignores]
 "examples/*" = ["D100", "E402"]
+"__init__.py" = ["F401"]
 
 
 [tool.ruff.lint.pydocstyle]

src/ansys/speos/core/workflow/combine_speos.py

@@ -21,7 +21,6 @@
 # SOFTWARE.
 """Import geometries and materials from several SPEOS files to a project."""
 
-import os
 from pathlib import Path
 from typing import List, Optional
 

tests/core/test_intensity.py

@@ -22,7 +22,6 @@
 
 """Test basic using intensity."""
 
-import os
 from pathlib import Path
 
 from ansys.speos.core import GeoRef, Intensity, Speos

tests/core/test_lxp.py

@@ -22,7 +22,6 @@
 
 """Test basic using lxp."""
 
-import os
 from pathlib import Path
 
 import ansys.speos.core.lxp as lxp

tests/core/test_opt_prop.py

@@ -22,7 +22,6 @@
 
 """Test basic using optical properties."""
 
-import os
 from pathlib import Path
 
 from ansys.speos.core import GeoRef, Project, Speos

tests/core/test_project.py

@@ -22,7 +22,6 @@
 
 """Test basic using project."""
 
-import os
 from pathlib import Path
 
 from ansys.speos.core import Body, Face, Part, Project, Speos
@@ -167,16 +166,16 @@ def test_find_feature_geom(speos: Speos):
     p2 = Project(speos=speos)
     root_part = p2.create_root_part()
     body_01 = root_part.create_body(name="Body.01")
-    face_011 = body_01.create_face(name="Face.011")
-    face_012 = body_01.create_face(name="Face.012")
-    body_02 = root_part.create_body(name="Body.02")
-    face_021 = body_01.create_face(name="Face.021")
+    body_01.create_face(name="Face.011")
+    body_01.create_face(name="Face.012")
+    root_part.create_body(name="Body.02")
+    body_01.create_face(name="Face.021")
     face_022 = body_01.create_face(name="Face.022")
-    face_023 = body_01.create_face(name="Face.023")
+    body_01.create_face(name="Face.023")
     sub_part_1 = root_part.create_sub_part(name="SubPart.1")
     body_1 = sub_part_1.create_body(name="Body.1")
-    face_11 = body_1.create_face(name="Face.11")
-    face_12 = body_1.create_face(name="Face.12")
+    body_1.create_face(name="Face.11")
+    body_1.create_face(name="Face.12")
     sub_part_11 = sub_part_1.create_sub_part(name="SubPart.11")
     body_11 = sub_part_11.create_body(name="Body.11")
     face_111 = body_11.create_face(name="Face.111")
@@ -185,7 +184,7 @@ def test_find_feature_geom(speos: Speos):
     body_2 = sub_part_2.create_body(name="Body.2")
     face_21 = body_2.create_face(name="Face.21")
     face_22 = body_2.create_face(name="Face.22")
-    face_23 = body_2.create_face(name="Face.23")
+    body_2.create_face(name="Face.23")
 
     # Look at first level : 2 Bodies and 2 SubParts
     found_feats = p2.find(name=".*", name_regex=True, feature_type=Part)

tests/core/test_proto_message_utils.py

@@ -22,7 +22,6 @@
 
 """Test basic using proto_message_utils."""
 
-import os
 from pathlib import Path
 
 from ansys.speos.core import OptProp, Project, Speos, proto_message_utils

tests/core/test_sensor.py

@@ -23,7 +23,6 @@
 """Test basic using sensor."""
 
 import math
-import os
 from pathlib import Path
 
 from ansys.api.speos.sensor.v1 import camera_sensor_pb2

tests/core/test_simulation.py

@@ -22,7 +22,6 @@
 
 """Test basic using simulation."""
 
-import os
 from pathlib import Path
 
 from ansys.api.speos.simulation.v1 import simulation_template_pb2

tests/core/test_source.py

@@ -22,7 +22,6 @@
 
 """Unit test for Source Class."""
 
-import os
 from pathlib import Path
 
 from ansys.speos.core import GeoRef, Project, Speos

tests/core/test_spectrum.py

@@ -22,7 +22,6 @@
 
 """Test basic using spectrums."""
 
-import os
 from pathlib import Path
 
 from ansys.speos.core import Spectrum, Speos

tests/helper.py

@@ -27,7 +27,6 @@
 in local.
 """
 
-import os
 from pathlib import Path
 import subprocess
 import time

tests/kernel/test_client.py

@@ -23,7 +23,6 @@
 """Test basic client connection."""
 
 from grpc import insecure_channel
-import pytest
 
 from ansys.speos.core.kernel.client import SpeosClient
 from ansys.speos.core.speos import Speos

tests/kernel/test_intensity_template.py

@@ -22,7 +22,6 @@
 
 """Test basic intensity template database connection."""
 
-import os
 from pathlib import Path
 
 from ansys.api.speos.common.v1 import data_pb2

tests/kernel/test_job.py

@@ -39,7 +39,7 @@ def test_job(speos: Speos):
     scene = create_basic_scene(speos)
     assert len(scene.get().simulations) == 4
 
-    job_dir = speos.client.jobs().create(
+    speos.client.jobs().create(
         message=ProtoJob(
             name="job_dir",
             scene_guid=scene.key,
@@ -50,7 +50,7 @@ def test_job(speos: Speos):
         )
     )
 
-    job_inv = speos.client.jobs().create(
+    speos.client.jobs().create(
         message=ProtoJob(
             name="job_inv",
             scene_guid=scene.key,
@@ -64,7 +64,7 @@ def test_job(speos: Speos):
         )
     )
 
-    job_int = speos.client.jobs().create(
+    speos.client.jobs().create(
         message=ProtoJob(
             name="job_int",
             scene_guid=scene.key,

tests/kernel/test_scene.py

@@ -22,7 +22,6 @@
 
 """Test scene."""
 
-import os
 from pathlib import Path
 from typing import List, Mapping, Optional
 

tests/kernel/test_sensor_template.py

@@ -22,7 +22,6 @@
 
 """Test source template."""
 
-import os
 from pathlib import Path
 
 from ansys.api.speos.sensor.v1 import (

tests/kernel/test_sop_template.py

@@ -23,7 +23,6 @@
 """Test basic sop template database connection."""
 
 import json
-import os
 from pathlib import Path
 
 import grpc

tests/kernel/test_source_template.py

@@ -23,7 +23,6 @@
 """Test source template."""
 
 import json
-import os
 from pathlib import Path
 
 import grpc

tests/kernel/test_spectrum.py

@@ -22,7 +22,6 @@
 
 """Test basic spectrum database connection."""
 
-import os
 from pathlib import Path
 
 from ansys.speos.core.kernel.spectrum import ProtoSpectrum

tests/kernel/test_vop_template.py

@@ -23,7 +23,6 @@
 """Test basic vop template database connection."""
 
 import json
-import os
 from pathlib import Path
 
 import grpc

tests/stubs/test_anisotropic_bsdf.py

@@ -23,7 +23,6 @@
 """Unit test for anisotropic bsdf service."""
 
 import math
-import os
 from pathlib import Path
 
 from google.protobuf.empty_pb2 import Empty

tests/stubs/test_bsdf_creation.py

@@ -23,7 +23,6 @@
 """Unit test for BSDF creation service."""
 
 import math
-import os
 from pathlib import Path
 
 import ansys.api.speos.bsdf.v1.bsdf_creation_pb2 as bsdf_creation__v1__pb2

tests/stubs/test_eulumdat_file.py

@@ -23,7 +23,6 @@
 """Unit Test for Eulumdat service."""
 
 import logging
-import os
 from pathlib import Path
 
 from ansys.api.speos.intensity_distributions.v1 import (
@@ -235,17 +234,17 @@ def test_grpc_eulumdat_intensity(speos: Speos):
     eulumdat = createEulumdatIntensity()
 
     logging.debug("Sending protocol buffer to server")
-    import_response = eulumdat_pb2.Import_Response()
-    import_response = stub.Import(eulumdat)
+    eulumdat_pb2.Import_Response()
+    stub.Import(eulumdat)
 
     logging.debug("Writing as {save_name.file_uri}")
-    save_response = eulumdat_pb2.Save_Response()
-    save_response = stub.Save(save_name)
+    eulumdat_pb2.Save_Response()
+    stub.Save(save_name)
     assert helper.does_file_exist(save_name.file_uri)
 
     logging.debug("Reading {load_name.file_uri} back")
-    load_response = eulumdat_pb2.Load_Response()
-    load_response = stub.Load(load_name)
+    eulumdat_pb2.Load_Response()
+    stub.Load(load_name)
     helper.remove_file(load_name.file_uri)
 
     logging.debug("Exporting eulumdat intensity protocol buffer")

tests/stubs/test_ies_file.py

@@ -23,7 +23,6 @@
 """Unit test for IES service."""
 
 import logging
-import os
 from pathlib import Path
 
 from ansys.api.speos.intensity_distributions.v1 import ies_pb2, ies_pb2_grpc
@@ -149,22 +148,22 @@ def test_grpc_ies_intensity(speos: Speos):
     ies = createIesIntensity()
 
     logging.debug("Sending protocol buffer to server")
-    import_response = ies_pb2.Import_Response()
-    import_response = stub.Import(ies)
+    ies_pb2.Import_Response()
+    stub.Import(ies)
 
     logging.debug("Writing as {save_request.file_uri}")
-    save_response = ies_pb2.Save_Response()
-    save_response = stub.Save(save_request)
+    ies_pb2.Save_Response()
+    stub.Save(save_request)
     assert helper.does_file_exist(save_request.file_uri)
 
     logging.debug("Reading {load_response.file_uri}")
-    load_response = ies_pb2.Load_Response()
-    load_response = stub.Load(load_request)
+    ies_pb2.Load_Response()
+    stub.Load(load_request)
     helper.remove_file(load_request.file_uri)
 
     logging.debug("Exporting ies intensity protocol buffer")
     export_request = ies_pb2.Export_Request()
-    ies2 = ies_pb2.IesIntensityDistribution()
+    ies_pb2.IesIntensityDistribution()
     ies2 = stub.Export(export_request)
 
     logging.debug("Comparing ies intensity distributions")

tests/stubs/test_lpf_file_reader.py

@@ -22,7 +22,6 @@
 
 """Unit test for LPF reader service."""
 
-import os
 from pathlib import Path
 
 import ansys.api.speos.file.v1.file_transfer as file_transfer_helper__v1

tests/stubs/test_spectral_bsdf.py

@@ -23,7 +23,6 @@
 """Unit tests for spectral BSDF service."""
 
 import math
-import os
 from pathlib import Path
 
 from google.protobuf.empty_pb2 import Empty

tests/stubs/test_xmp_intensity_file.py

@@ -23,7 +23,6 @@
 """Unit test for Intensity XMP service."""
 
 import logging
-import os
 from pathlib import Path
 
 from ansys.api.speos.intensity_distributions.v1 import (

tests/stubs/test_xmp_spectral_intensity_file.py

@@ -23,7 +23,6 @@
 """Unit test for spectral Intensity XMP service."""
 
 import logging
-import os
 from pathlib import Path
 
 from ansys.api.speos.intensity_distributions.v1 import (

tests/workflow/test_combine_speos.py

@@ -22,7 +22,6 @@
 
 """Test using combine_speos module in workflow layer."""
 
-import os
 from pathlib import Path
 
 from ansys.speos.core import OptProp, Part, Project, Speos