Skip to content

Improving post mortem info #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 22, 2022
Merged

Improving post mortem info #1344

merged 16 commits into from
Aug 22, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 11, 2022

Because many fails in #1343 I think we need better info about why the docker image is dying.

So I'm attempting to retrieve all the err, out and log files. Also I have added the crash file.

@germa89 germa89 added Enhancement CI/CD Related with CICD, Github Actions, etc labels Aug 11, 2022
@germa89 germa89 self-assigned this Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #1344 (99d7d4a) into main (efc02a9) will increase coverage by 0.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1344      +/-   ##
==========================================
+ Coverage   75.91%   76.64%   +0.73%     
==========================================
  Files          43       43              
  Lines        6813     6860      +47     
==========================================
+ Hits         5172     5258      +86     
+ Misses       1641     1602      -39     

@germa89
Copy link
Collaborator Author

germa89 commented Aug 21, 2022

I will add this to the MAPDL nightly.

@germa89
Copy link
Collaborator Author

germa89 commented Aug 21, 2022

The nightlies work fine.

Ready for review!

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Thanks for adding this. Now we have more logs to debug the failures.

@germa89 germa89 merged commit 85ee08c into main Aug 22, 2022
@germa89 germa89 deleted the feat/improving-post-mortem-info branch August 22, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants